piix_pci: change the i440fx data sheet link

[Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link

Li Qiang posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181011144451.38042-1-liq3ea@163.com

Test docker-clang@ubuntu passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

hw/pci-host/piix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link

Posted by Li Qiang 7 years ago

Seems the intel link is unavailable, change it to qemu site.

Signed-off-by: Li Qiang <liq3ea@163.com>
---
 hw/pci-host/piix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e608347c1..e709abeb08 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -40,7 +40,7 @@
 
 /*
  * I440FX chipset data sheet.
- * http://download.intel.com/design/chipsets/datashts/29054901.pdf
+ * https://wiki.qemu.org/images/b/bb/29054901.pdf
  */
 
 #define I440FX_PCI_HOST_BRIDGE(obj) \
-- 
2.17.1

Re: [Qemu-devel] [PATCH] piix_pci: change the i440fx data sheet link

Posted by Philippe Mathieu-Daudé 7 years ago

Hi Li,

On 11/10/2018 16:44, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
> 
> Signed-off-by: Li Qiang <liq3ea@163.com>
> ---
>  hw/pci-host/piix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..e709abeb08 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>  
>  /*
>   * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/images/b/bb/29054901.pdf

Good idea, but please use: https://wiki.qemu.org/File:29054901.pdf

With this change:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>   */
>  
>  #define I440FX_PCI_HOST_BRIDGE(obj) \
> 

Thanks,

Phil.