[Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking

Fam Zheng posted 3 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181011072135.588-1-famz@redhat.com
Test docker-clang@ubuntu passed
Test checkpatch passed
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
block/file-posix.c         |  83 +++++++++++++-------
tests/Makefile.include     |   2 +
tests/test-image-locking.c | 157 +++++++++++++++++++++++++++++++++++++
3 files changed, 212 insertions(+), 30 deletions(-)
create mode 100644 tests/test-image-locking.c
[Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking
Posted by Fam Zheng 7 years ago
v5: Address Max's comments (Thanks for reviewing):
    - Clean up after test done.
    - Add rev-by to patch 1 and 2.

v4: Fix test on systems without OFD. [Patchew]

The first patch reduces chances of QEMU crash in unusual (but not unlikely)
cases especially when used by Libvirt (see commit message).

The second patch halves fd for images.

The third adds some more test for patch one (would have caught the regression
caused by v2).

Fam Zheng (3):
  file-posix: Skip effectiveless OFD lock operations
  file-posix: Drop s->lock_fd
  tests: Add unit tests for image locking

 block/file-posix.c         |  83 +++++++++++++-------
 tests/Makefile.include     |   2 +
 tests/test-image-locking.c | 157 +++++++++++++++++++++++++++++++++++++
 3 files changed, 212 insertions(+), 30 deletions(-)
 create mode 100644 tests/test-image-locking.c

-- 
2.17.1


Re: [Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking
Posted by Fam Zheng 6 years, 12 months ago
On Thu, 10/11 15:21, Fam Zheng wrote:
> v5: Address Max's comments (Thanks for reviewing):
>     - Clean up after test done.
>     - Add rev-by to patch 1 and 2.

Ping?

Fam

Re: [Qemu-devel] [PATCH v5 0/3] file-posix: Simplifications on image locking
Posted by Kevin Wolf 6 years, 12 months ago
Am 11.10.2018 um 09:21 hat Fam Zheng geschrieben:
> v5: Address Max's comments (Thanks for reviewing):
>     - Clean up after test done.
>     - Add rev-by to patch 1 and 2.
> 
> v4: Fix test on systems without OFD. [Patchew]
> 
> The first patch reduces chances of QEMU crash in unusual (but not unlikely)
> cases especially when used by Libvirt (see commit message).
> 
> The second patch halves fd for images.
> 
> The third adds some more test for patch one (would have caught the regression
> caused by v2).

Thanks, applied to the block branch.

Kevin