Trivial fixes and clean ups

[Qemu-devel] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes

Posted by Cleber Rosa 7 years, 4 months ago

Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
 scripts/decodetree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 457cffea90..37c76b5507 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -298,7 +298,7 @@ class Field:
             s = 's'
         else:
             s = ''
-        return str(pos) + ':' + s + str(len)
+        return str(self.pos) + ':' + s + str(self.len)
 
     def str_extract(self):
         if self.sign:
-- 
2.17.1

Re: [Qemu-devel] [PATCH 08/10] scripts/decodetree.py: fix reference to attributes

Posted by Philippe Mathieu-Daudé 7 years, 4 months ago

On 04/10/2018 18:18, Cleber Rosa wrote:
> Signed-off-by: Cleber Rosa <crosa@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  scripts/decodetree.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 457cffea90..37c76b5507 100755
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -298,7 +298,7 @@ class Field:
>              s = 's'
>          else:
>              s = ''
> -        return str(pos) + ':' + s + str(len)
> +        return str(self.pos) + ':' + s + str(self.len)
>  
>      def str_extract(self):
>          if self.sign:
>