[v2] per-TLB lock

[Qemu-devel] [PATCH v2 0/4] per-TLB lock

Posted by Emilio G. Cota 5 years, 6 months ago

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00395.html

Changes since v1:

- Rebase on master

- Expand lock usage to other tlb_table/tlb_v_table updates, which I
  missed in v1

- Fix assert_cpu_is_self macro

- Add comment on why the owner thread doesn't need to use atomic_set
  for updates

- Add more calls to assert_cpu_is_self macro, which together with
  the added comment should make the code simpler to understand

- Include perf numbers in the last patch

The series is checkpatch-clean. You can fetch the code from:
  https://github.com/cota/qemu/tree/tlb-lock-v2

Thanks,

		Emilio

Re: [Qemu-devel] [PATCH v2 0/4] per-TLB lock

Posted by Alex Bennée 5 years, 6 months ago

Emilio G. Cota <cota@braap.org> writes:

> v1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00395.html
>
> Changes since v1:
>
> - Rebase on master
>
> - Expand lock usage to other tlb_table/tlb_v_table updates, which I
>   missed in v1
>
> - Fix assert_cpu_is_self macro
>
> - Add comment on why the owner thread doesn't need to use atomic_set
>   for updates
>
> - Add more calls to assert_cpu_is_self macro, which together with
>   the added comment should make the code simpler to understand
>
> - Include perf numbers in the last patch
>
> The series is checkpatch-clean. You can fetch the code from:
>   https://github.com/cota/qemu/tree/tlb-lock-v2

Weird build failure aside I gave it a good build test soak which usually
trips up TLB issues.

Tested-by: Alex Bennée <alex.bennee@linaro.org>

--
Alex Bennée