[v1] Option patches

[Qemu-devel] [PULL 00/12] Option patches

Marc-André Lureau posted 12 patches 5 years, 6 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181003141833.21493-1-marcandre.lureau@redhat.com

Test docker-clang@ubuntu failed

Test checkpatch passed

There is a newer version of this series

include/monitor/monitor.h  |  3 ++
include/qemu/cutils.h      | 12 +++++++
backends/hostmem-memfd.c   |  9 +++++
backends/hostmem.c         | 14 ++++++++
monitor.c                  | 16 +++++++--
qdev-monitor.c             | 32 ++++++++++-------
qom/object.c               |  9 ++---
qom/object_interfaces.c    |  6 ++--
tests/check-qom-proplist.c | 58 ++++++++++++++++++++-----------
util/cutils.c              |  5 +++
util/qemu-option.c         | 71 +++++++++++++++++++++++++++++++-------
vl.c                       | 53 ++++++++++++++++++++++++++--
12 files changed, 228 insertions(+), 60 deletions(-)

Expand all Fold all

[Qemu-devel] [PULL 00/12] Option patches

Posted by Marc-André Lureau 5 years, 6 months ago

The following changes since commit dafd95053611aa14dda40266857608d12ddce658:

  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-02 18:27:18 +0100)

are available in the Git repository at:

  https://github.com/elmarco/qemu.git tags/option-pull-request

for you to fetch changes up to 9066f2c2b6494206839835c9d37482425e1983d9:

  vl: list user creatable properties when 'help' is argument (2018-10-03 18:03:17 +0400)

----------------------------------------------------------------
CLI help improvements

----------------------------------------------------------------

Marc-André Lureau (12):
  qdev-monitor: print help to stdout
  cutils: add qemu_pstrcmp0()
  qemu-option: add help fallback to print the list of options
  qemu-option: improve qemu_opts_print_help() output
  qom/object: fix iterating properties over a class
  qom/object: register 'type' property as class property
  tests/qom-proplist: check duplicate "bv" property registration failed
  tests/qom-proplist: check properties are not listed multiple times
  tests/qom-proplist: check class properties iterator
  vl: handle -object help
  hostmem: add some properties description
  vl: list user creatable properties when 'help' is argument

 include/monitor/monitor.h  |  3 ++
 include/qemu/cutils.h      | 12 +++++++
 backends/hostmem-memfd.c   |  9 +++++
 backends/hostmem.c         | 14 ++++++++
 monitor.c                  | 16 +++++++--
 qdev-monitor.c             | 32 ++++++++++-------
 qom/object.c               |  9 ++---
 qom/object_interfaces.c    |  6 ++--
 tests/check-qom-proplist.c | 58 ++++++++++++++++++++-----------
 util/cutils.c              |  5 +++
 util/qemu-option.c         | 71 +++++++++++++++++++++++++++++++-------
 vl.c                       | 53 ++++++++++++++++++++++++++--
 12 files changed, 228 insertions(+), 60 deletions(-)

-- 
2.19.0.271.gfe8321ec05

Re: [Qemu-devel] [PULL 00/12] Option patches

Posted by Peter Maydell 5 years, 6 months ago

On 3 October 2018 at 15:18, Marc-André Lureau
<marcandre.lureau@redhat.com> wrote:
> The following changes since commit dafd95053611aa14dda40266857608d12ddce658:
>
>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2018-10-02 18:27:18 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/elmarco/qemu.git tags/option-pull-request
>
> for you to fetch changes up to 9066f2c2b6494206839835c9d37482425e1983d9:
>
>   vl: list user creatable properties when 'help' is argument (2018-10-03 18:03:17 +0400)
>
> ----------------------------------------------------------------
> CLI help improvements
>
> ----------------------------------------------------------------

Hi. This seems to fail "make check" on all platforms:

MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
gtester -k --verbose -m=quick t
ests/check-qom-proplist
TEST: tests/check-qom-proplist... (pid=21624)
  /qom/proplist/createlist:                                            OK
  /qom/proplist/createv:                                               OK
  /qom/proplist/createcmdline:                                         OK
  /qom/proplist/badenum:                                               OK
  /qom/proplist/getenum:                                               OK
Found prop 'type'
  /qom/proplist/iterator:                                              **
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/check-qom-proplist.c:540:test_dummy_prop_itera
tor: code should not be reached
FAIL
GTester: last random seed: R02S55ffa6110c89eb6405f845acf4ca5558
(pid=21627)
  /qom/proplist/class_iterator:
Found prop 'type'
**
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/check-qom-proplist.c:540:test_dummy_prop_itera
tor: code should not be reached
FAIL
GTester: last random seed: R02Scdce3ab505045deea3b5df4d6b7e75c8
(pid=21629)
  /qom/proplist/delchild:                                              OK
  /qom/resolve/partial:                                                OK
FAIL: tests/check-qom-proplist
/home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:925:
recipe for target 'check-tests
/check-qom-proplist' failed

thanks
-- PMM