configure: remove glib_subprocess check

[Qemu-devel] [PATCH] configure: remove glib_subprocess check

Posted by Marc-André Lureau 5 years, 6 months ago

This should have been removed as part of commit
692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 configure | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/configure b/configure
index a7368044cc..4f6d6e03b1 100755
--- a/configure
+++ b/configure
@@ -3557,12 +3557,6 @@ if ! compile_prog "$CFLAGS" "$LIBS" ; then
 	       "build target"
 fi
 
-# g_test_trap_subprocess added in 2.38. Used by some tests.
-glib_subprocess=yes
-if ! $pkg_config --atleast-version=2.38 glib-2.0; then
-    glib_subprocess=no
-fi
-
 # Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
 cat > $TMPC << EOF
 #include <glib.h>
-- 
2.19.0.271.gfe8321ec05

Re: [Qemu-devel] [PATCH] configure: remove glib_subprocess check

Posted by Philippe Mathieu-Daudé 5 years, 6 months ago

On 03/10/2018 15:20, Marc-André Lureau wrote:
> This should have been removed as part of commit
> 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  configure | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/configure b/configure
> index a7368044cc..4f6d6e03b1 100755
> --- a/configure
> +++ b/configure
> @@ -3557,12 +3557,6 @@ if ! compile_prog "$CFLAGS" "$LIBS" ; then
>  	       "build target"
>  fi
>  
> -# g_test_trap_subprocess added in 2.38. Used by some tests.
> -glib_subprocess=yes
> -if ! $pkg_config --atleast-version=2.38 glib-2.0; then
> -    glib_subprocess=no
> -fi
> -
>  # Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
>  cat > $TMPC << EOF
>  #include <glib.h>
>

Re: [Qemu-devel] [PATCH] configure: remove glib_subprocess check

Posted by Thomas Huth 5 years, 6 months ago

On 2018-10-03 15:20, Marc-André Lureau wrote:
> This should have been removed as part of commit
> 692fbdf9f4c6f6bafd0b3a4d4f94973effd3bbae.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/configure b/configure
> index a7368044cc..4f6d6e03b1 100755
> --- a/configure
> +++ b/configure
> @@ -3557,12 +3557,6 @@ if ! compile_prog "$CFLAGS" "$LIBS" ; then
>  	       "build target"
>  fi
>  
> -# g_test_trap_subprocess added in 2.38. Used by some tests.
> -glib_subprocess=yes
> -if ! $pkg_config --atleast-version=2.38 glib-2.0; then
> -    glib_subprocess=no
> -fi
> -
>  # Silence clang 3.5.0 warnings about glib attribute __alloc_size__ usage
>  cat > $TMPC << EOF
>  #include <glib.h>
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>