Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ce7c351afa..2708745bf7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -188,6 +188,7 @@ F: disas/microblaze.c
 MIPS
 M: Aurelien Jarno <aurelien@aurel32.net>
 M: Aleksandar Markovic <amarkovic@wavecomp.com>
+R: Philippe Mathieu-Daudé <f4bug@amsat.org>
 S: Maintained
 F: target/mips/
 F: hw/mips/
@@ -1948,6 +1949,7 @@ F: disas/i386.c
 
 MIPS target
 M: Aurelien Jarno <aurelien@aurel32.net>
+R: Philippe Mathieu-Daudé <f4bug@amsat.org>
 S: Maintained
 F: tcg/mips/
 F: disas/mips.c
-- 
2.19.0

Eric corrected s/Voluntary/Volunteer/ in the subject line.

On 9/30/18 11:47 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ce7c351afa..2708745bf7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -188,6 +188,7 @@ F: disas/microblaze.c
>  MIPS
>  M: Aurelien Jarno <aurelien@aurel32.net>
>  M: Aleksandar Markovic <amarkovic@wavecomp.com>
> +R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  S: Maintained
>  F: target/mips/
>  F: hw/mips/
> @@ -1948,6 +1949,7 @@ F: disas/i386.c
>  
>  MIPS target
>  M: Aurelien Jarno <aurelien@aurel32.net>
> +R: Philippe Mathieu-Daudé <f4bug@amsat.org>
>  S: Maintained
>  F: tcg/mips/
>  F: disas/mips.c
> 

> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> on behalf of Philippe Mathieu-Daudé <f4bug@amsat.org>
> Subject: [PATCH v3 4/4] MAINTAINERS: Voluntary to review hobbyist MIPS contributions
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)

This is very generous of you. However, I would prefer registered reviewers of MIPS directories to be persons more focused on MIPS. But thanks again.

Aleksandar

Hi Aleksandar,

On Wed, Oct 17, 2018 at 2:15 PM Aleksandar Markovic
<amarkovic@wavecomp.com> wrote:
> > From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> on behalf of Philippe Mathieu-Daudé <f4bug@amsat.org>
> > Subject: [PATCH v3 4/4] MAINTAINERS: Voluntary to review hobbyist MIPS contributions
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
>
> This is very generous of you. However, I would prefer registered reviewers of MIPS directories to be persons more focused on MIPS. But thanks again.

In MAINTAINERS the 'R:' tag simply means "These reviewers should be
CCed on patches."

This is just used by the get_maintainer script to see to who send patches to.
This is not about responsibility nor ownership.

The guideline on the wiki
https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer
says:
  "In fact, you can automate this, via a one-time setup of git config
sendemail.cccmd 'scripts/get_maintainer.pl --nogit-fallback'."

So you end up with:

$ grep -A2 email .git/config
[sendemail]
    confirm = auto
    cccmd = scripts/get_maintainer.pl --nogit-fallback --noroles --n
--m --r --remove-duplicates

As an example, if you check the "Unimp device" section:

Unimplemented device
M: Peter Maydell <peter.maydell@linaro.org>
R: Philippe Mathieu-Daudé <f4bug@amsat.org>
S: Maintained
F: include/hw/misc/unimp.h
F: hw/misc/unimp.c

I'm not a maintainer, Peter is. I have no obligation to review
patches, I am simply interested to not loose them in the traffic.
With the 'R:' tag my email appears in the list:

$ ./scripts/get_maintainer.pl -f hw/misc/unimp.c
Peter Maydell <peter.maydell@linaro.org> (maintainer:Unimplemented device)
"Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:Unimplemented device)
qemu-devel@nongnu.org (open list:All patches CC here)

Anyway I'm fine with that patch not being applied, and now I even
prefer it is not.

I found a kludge using the "to: (qemu-devel@nongnu.org
aurelien@aurel32.net amarkovic@wavecomp.com)" email filter. If an
email is sent to the list and both of you, it is very likely this is
MIPS related.

Regards,

Phil.