After noticing Fredrik patch [1] clashes with an ongoing work, I shared my
concerns after the current limitations of CPUMIPSState::insn_flags, having
1 bit left to store more 'Chip specific instructions'.

Since v1: https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg00933.html

- update "int insn_flags;" in target/mips/translate.c::DisasContext
- cleaned the 'insn_flags' namespace per Aleksandar suggestion
- drop cpu defs used once
- add my email in MAINTAINERS:MIPS to help me catch patches to review

Regards,

Phil.

[1] http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg01978.html
[2] http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg00901.html

Based-on: cover.1538240994.git.noring@nocrew.org

Philippe Mathieu-Daudé (4):
  target/mips: Increase the 'supported instructions' flags holder size
  target/mips: Remove definitions that are only used once
  target/mips: Clean the 'insn_flags' namespace
  MAINTAINERS: Voluntary to review hobbyist MIPS contributions

 target/mips/cpu.h                |  2 +-
 target/mips/internal.h           |  2 +-
 target/mips/mips-defs.h          | 92 ++++++++++++++++++--------------
 target/mips/translate.c          |  8 +--
 target/mips/translate_init.inc.c |  8 +--
 MAINTAINERS                      |  2 +
 6 files changed, 64 insertions(+), 50 deletions(-)

-- 
2.19.0

Hi, Philippe!

> From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> on behalf of Philippe Mathieu-Daudé <f4bug@amsat.org>

> After noticing Fredrik patch [1] clashes with an ongoing work, I shared my
concerns after the current limitations of CPUMIPSState::insn_flags, having
1 bit left to store more 'Chip specific instructions'.

This series can't be applied to QEMU ToT (the culprit: R5900) - I already brought a similar issue to your attention in v1. You shouldn't mix R5900 with other patches in this series.

Also, the title and the cover letter text do not correspond well to the content to the series.

Thanks,
Aleksandar

On 9/30/18 10:27 PM, Aleksandar Markovic wrote:
> Hi, Philippe!
> 
>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
>> After noticing Fredrik patch [1] clashes with an ongoing work, I shared my
> concerns after the current limitations of CPUMIPSState::insn_flags, having
> 1 bit left to store more 'Chip specific instructions'.
> 
> This series can't be applied to QEMU ToT (the culprit: R5900) - I already brought a similar issue to your attention in v1. You shouldn't mix R5900 with other patches in this series.

Oops you right, sorry.

> 
> Also, the title and the cover letter text do not correspond well to the content to the series.

Hmm the content is not far from the title, I'll see how to reword that.

Anyway keeping the same series subject on respin help for tools such
patchwork and patchew.

Thanks,

Phil.