[v2] target/arm: Rely on id regs instead of features

[Qemu-devel] [PATCH v2 3/9] target/arm: Align cortex-r5 id_isar0

Posted by Richard Henderson 7 years, 4 months ago

The missing nibble made it more difficult to read.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 17c9c43f41..03bf28f533 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1397,7 +1397,7 @@ static void cortex_r5_initfn(Object *obj)
     cpu->id_mmfr1 = 0x00000000;
     cpu->id_mmfr2 = 0x01200000;
     cpu->id_mmfr3 = 0x0211;
-    cpu->id_isar0 = 0x2101111;
+    cpu->id_isar0 = 0x02101111;
     cpu->id_isar1 = 0x13112111;
     cpu->id_isar2 = 0x21232141;
     cpu->id_isar3 = 0x01112131;
-- 
2.17.1

Re: [Qemu-devel] [PATCH v2 3/9] target/arm: Align cortex-r5 id_isar0

Posted by Philippe Mathieu-Daudé 7 years, 4 months ago

On 27/09/2018 22:13, Richard Henderson wrote:
> The missing nibble made it more difficult to read.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  target/arm/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index 17c9c43f41..03bf28f533 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -1397,7 +1397,7 @@ static void cortex_r5_initfn(Object *obj)
>      cpu->id_mmfr1 = 0x00000000;
>      cpu->id_mmfr2 = 0x01200000;
>      cpu->id_mmfr3 = 0x0211;
> -    cpu->id_isar0 = 0x2101111;
> +    cpu->id_isar0 = 0x02101111;
>      cpu->id_isar1 = 0x13112111;
>      cpu->id_isar2 = 0x21232141;
>      cpu->id_isar3 = 0x01112131;
>