[Qemu-devel] [PULL 11/16] migration/postcopy: Clear have_listen_thread

Dr. David Alan Gilbert (git) posted 16 patches 7 years, 4 months ago
There is a newer version of this series
[Qemu-devel] [PULL 11/16] migration/postcopy: Clear have_listen_thread
Posted by Dr. David Alan Gilbert (git) 7 years, 4 months ago
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Clear have_listen_thread when we exit the thread.
The fallout from this was that various things thought there was
an ongoing postcopy after the postcopy had finished.

The case that failed was postcopy->savevm->loadvm.

This corresponds to RH bug https://bugzilla.redhat.com/show_bug.cgi?id=1608765

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20180914170430.54271-2-dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 migration/savevm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/migration/savevm.c b/migration/savevm.c
index 9692577318..d35e87b88c 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1679,6 +1679,7 @@ static void *postcopy_ram_listen_thread(void *opaque)
     qemu_loadvm_state_cleanup();
 
     rcu_unregister_thread();
+    mis->have_listen_thread = false;
     return NULL;
 }
 
-- 
2.17.1