[v4] memory-device: complete refactoring + virtio-pmem

[Qemu-devel] [PATCH v4 01/24] memory-device: fix alignment error message

Posted by David Hildenbrand 7 years, 4 months ago

We're missing "x" after the leading 0.

Signed-off-by: David Hildenbrand <david@redhat.com>
---
 hw/mem/memory-device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 6de4f70bb4..0b52fe2c5e 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -120,7 +120,7 @@ uint64_t memory_device_get_free_addr(MachineState *ms, const uint64_t *hint,
 
     /* address_space_start indicates the maximum alignment we expect */
     if (QEMU_ALIGN_UP(address_space_start, align) != address_space_start) {
-        error_setg(errp, "the alignment (0%" PRIx64 ") is not supported",
+        error_setg(errp, "the alignment (0x%" PRIx64 ") is not supported",
                    align);
         return 0;
     }
-- 
2.17.1

Re: [Qemu-devel] [PATCH v4 01/24] memory-device: fix alignment error message

Posted by David Gibson 7 years, 4 months ago

On Wed, Sep 26, 2018 at 11:41:56AM +0200, David Hildenbrand wrote:
> We're missing "x" after the leading 0.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  hw/mem/memory-device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index 6de4f70bb4..0b52fe2c5e 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -120,7 +120,7 @@ uint64_t memory_device_get_free_addr(MachineState *ms, const uint64_t *hint,
>  
>      /* address_space_start indicates the maximum alignment we expect */
>      if (QEMU_ALIGN_UP(address_space_start, align) != address_space_start) {
> -        error_setg(errp, "the alignment (0%" PRIx64 ") is not supported",
> +        error_setg(errp, "the alignment (0x%" PRIx64 ") is not supported",
>                     align);
>          return 0;
>      }

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [PATCH v4 01/24] memory-device: fix alignment error message

Posted by Igor Mammedov 7 years, 4 months ago

On Wed, 26 Sep 2018 11:41:56 +0200
David Hildenbrand <david@redhat.com> wrote:

> We're missing "x" after the leading 0.
> 
> Signed-off-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>

> ---
>  hw/mem/memory-device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index 6de4f70bb4..0b52fe2c5e 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -120,7 +120,7 @@ uint64_t memory_device_get_free_addr(MachineState *ms, const uint64_t *hint,
>  
>      /* address_space_start indicates the maximum alignment we expect */
>      if (QEMU_ALIGN_UP(address_space_start, align) != address_space_start) {
> -        error_setg(errp, "the alignment (0%" PRIx64 ") is not supported",
> +        error_setg(errp, "the alignment (0x%" PRIx64 ") is not supported",
>                     align);
>          return 0;
>      }