hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

[Qemu-devel] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

Peter Maydell posted 1 patch 7 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180924123122.14549-1-peter.maydell@linaro.org

Test docker-clang@ubuntu failed

Test checkpatch passed

hw/timer/cmsdk-apb-dualtimer.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

Posted by Peter Maydell 7 years, 1 month ago

Add 'break' statements missing from a switch in the APB dual-timer
write function. Spotted by Coverity as CID 1395626 and 1395633.

Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/cmsdk-apb-dualtimer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/timer/cmsdk-apb-dualtimer.c b/hw/timer/cmsdk-apb-dualtimer.c
index ccd49753b7f..30245990f34 100644
--- a/hw/timer/cmsdk-apb-dualtimer.c
+++ b/hw/timer/cmsdk-apb-dualtimer.c
@@ -296,9 +296,11 @@ static void cmsdk_apb_dualtimer_write(void *opaque, hwaddr offset,
         case A_TIMERITCR:
             s->timeritcr = value & R_TIMERITCR_VALID_MASK;
             cmsdk_apb_dualtimer_update(s);
+            break;
         case A_TIMERITOP:
             s->timeritop = value & R_TIMERITOP_VALID_MASK;
             cmsdk_apb_dualtimer_update(s);
+            break;
         default:
         bad_offset:
             qemu_log_mask(LOG_GUEST_ERROR,
-- 
2.19.0

Re: [Qemu-devel] [Qemu-arm] [PATCH] hw/timer/cmsdk-apb-dualtimer: Add missing 'break' statements

Posted by Philippe Mathieu-Daudé 7 years, 1 month ago

On 9/24/18 2:31 PM, Peter Maydell wrote:
> Add 'break' statements missing from a switch in the APB dual-timer
> write function. Spotted by Coverity as CID 1395626 and 1395633.
> 
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/timer/cmsdk-apb-dualtimer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/timer/cmsdk-apb-dualtimer.c b/hw/timer/cmsdk-apb-dualtimer.c
> index ccd49753b7f..30245990f34 100644
> --- a/hw/timer/cmsdk-apb-dualtimer.c
> +++ b/hw/timer/cmsdk-apb-dualtimer.c
> @@ -296,9 +296,11 @@ static void cmsdk_apb_dualtimer_write(void *opaque, hwaddr offset,
>          case A_TIMERITCR:
>              s->timeritcr = value & R_TIMERITCR_VALID_MASK;
>              cmsdk_apb_dualtimer_update(s);
> +            break;
>          case A_TIMERITOP:
>              s->timeritop = value & R_TIMERITOP_VALID_MASK;
>              cmsdk_apb_dualtimer_update(s);
> +            break;
>          default:
>          bad_offset:
>              qemu_log_mask(LOG_GUEST_ERROR,
>