exec: drop BQL from interrupt handling

[Qemu-devel] [PATCH 16/35] target/m68k: access cpu->interrupt_request with atomics

Posted by Emilio G. Cota 7 years, 1 month ago

From: Paolo Bonzini <pbonzini@redhat.com>

Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Emilio G. Cota <cota@braap.org>
---
 target/m68k/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
index 582e3a73b3..4b15184a50 100644
--- a/target/m68k/cpu.c
+++ b/target/m68k/cpu.c
@@ -34,7 +34,7 @@ static void m68k_cpu_set_pc(CPUState *cs, vaddr value)
 
 static bool m68k_cpu_has_work(CPUState *cs)
 {
-    return cs->interrupt_request & CPU_INTERRUPT_HARD;
+    return atomic_read(&cs->interrupt_request) & CPU_INTERRUPT_HARD;
 }
 
 static void m68k_set_feature(CPUM68KState *env, int feature)
-- 
2.17.1

Re: [Qemu-devel] [PATCH 16/35] target/m68k: access cpu->interrupt_request with atomics

Posted by Laurent Vivier 7 years, 1 month ago

Le 17/09/2018 à 18:30, Emilio G. Cota a écrit :
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  target/m68k/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
> index 582e3a73b3..4b15184a50 100644
> --- a/target/m68k/cpu.c
> +++ b/target/m68k/cpu.c
> @@ -34,7 +34,7 @@ static void m68k_cpu_set_pc(CPUState *cs, vaddr value)
>  
>  static bool m68k_cpu_has_work(CPUState *cs)
>  {
> -    return cs->interrupt_request & CPU_INTERRUPT_HARD;
> +    return atomic_read(&cs->interrupt_request) & CPU_INTERRUPT_HARD;
>  }
>  
>  static void m68k_set_feature(CPUM68KState *env, int feature)
> 

Acked-by: Laurent Vivier <laurent@vivier.eu>

Re: [Qemu-devel] [PATCH 16/35] target/m68k: access cpu->interrupt_request with atomics

Posted by Philippe Mathieu-Daudé 7 years, 1 month ago

On 9/17/18 6:30 PM, Emilio G. Cota wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
> 
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Emilio G. Cota <cota@braap.org>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  target/m68k/cpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/m68k/cpu.c b/target/m68k/cpu.c
> index 582e3a73b3..4b15184a50 100644
> --- a/target/m68k/cpu.c
> +++ b/target/m68k/cpu.c
> @@ -34,7 +34,7 @@ static void m68k_cpu_set_pc(CPUState *cs, vaddr value)
>  
>  static bool m68k_cpu_has_work(CPUState *cs)
>  {
> -    return cs->interrupt_request & CPU_INTERRUPT_HARD;
> +    return atomic_read(&cs->interrupt_request) & CPU_INTERRUPT_HARD;
>  }
>  
>  static void m68k_set_feature(CPUM68KState *env, int feature)
>