Usb 20180917 patches

[Qemu-devel] [PULL 0/6] Usb 20180917 patches

Posted by Gerd Hoffmann 7 years, 1 month ago

The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)

are available in the git repository at:

  git://git.kraxel.org/qemu tags/usb-20180917-pull-request

for you to fetch changes up to 5ef919130963ba478a65b1e559c71b876025cff7:

  usb: assign unique serial numbers to hid devices (2018-09-17 11:54:26 +0200)

----------------------------------------------------------------
usb: bugfixes for mtp, hub and hid devices.

----------------------------------------------------------------

Bandan (2):
  usb-mtp: fix error conditions for write operation
  doc: replace x-root with rootdir for usb-mtp

Bandan Das (1):
  usb-mtp: reset ObjectInfo dataset size on cleanup

Gerd Hoffmann (3):
  usb-hub: clear suspend on detach
  usb: add config options for hub and hid devices (kbd, mouse, tablet).
  usb: assign unique serial numbers to hid devices

 include/hw/compat.h       | 14 +++++++++++++-
 hw/usb/dev-hid.c          | 24 +++++++++++++-----------
 hw/usb/dev-hub.c          |  4 ++++
 hw/usb/dev-mtp.c          |  9 ++++++---
 default-configs/usb.mak   |  2 ++
 hw/usb/Makefile.objs      |  4 ++--
 qemu-doc.texi             |  2 +-
 scripts/device-crash-test |  2 +-
 8 files changed, 42 insertions(+), 19 deletions(-)

-- 
2.9.3

Re: [Qemu-devel] [PULL 0/6] Usb 20180917 patches

Posted by Peter Maydell 7 years, 1 month ago

On 17 September 2018 at 10:56, Gerd Hoffmann <kraxel@redhat.com> wrote:
> The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)
>
> are available in the git repository at:
>
>   git://git.kraxel.org/qemu tags/usb-20180917-pull-request
>
> for you to fetch changes up to 5ef919130963ba478a65b1e559c71b876025cff7:
>
>   usb: assign unique serial numbers to hid devices (2018-09-17 11:54:26 +0200)
>
> ----------------------------------------------------------------
> usb: bugfixes for mtp, hub and hid devices.
>

Hi. This seems to fail 'make check' on x86-64 Linux host:

TEST: tests/qom-test... (pid=27321)
  /sh4/qom/none:                                                       OK
  /sh4/qom/shix:                                                       OK
  /sh4/qom/r2d:
Unexpected error in u
sb_try_create_simple() at
/home/petmay01/linaro/qemu-for-merges/hw/usb/bus.c:338:
qemu-system-sh4: Failed to create USB device 'usb-kbd'
Broken pipe
/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:129:
kill_qemu() detected QEMU death
from signal 6 (Aborted) (core dumped)
FAIL
GTester: last random seed: R02S8e2f5918ab744c8a831cb30dc22eb415
(pid=27435)
FAIL: tests/qom-test
TEST: tests/test-hmp... (pid=27445)
  /sh4/hmp/none:                                                       OK
  /sh4/hmp/shix:                                                       OK
  /sh4/hmp/r2d:
Unexpected error in usb_try_create_simple() at
/home/petmay01/linaro/qemu-for-merges/hw/usb/bus.c:338:
qemu-system-sh4: Failed to create USB device 'usb-kbd'
Broken pipe
/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:129:
kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped)
FAIL
GTester: last random seed: R02S4db7d26cb963a488de3f32b59ccb8e59
(pid=27545)
  /sh4/hmp/none+2MB:                                                   OK
FAIL: tests/test-hmp
/home/petmay01/linaro/qemu-for-merges/tests/Makefile.include:905:
recipe for target 'check-qtest-sh4' failed

sh4eb fails the same way. ppc fails like this:

TEST: tests/boot-serial-test... (pid=26376)
  /ppc/boot-serial/ppce500:                                            OK
  /ppc/boot-serial/40p:                                                OK
  /ppc/boot-serial/g3beige:                                            OK
  /ppc/boot-serial/mac99:                                              OK
  /ppc/boot-serial/sam460ex:
Unexpected error in usb_try_create_simple() at
/home/petmay01/linaro/qemu-for-merges/hw/usb/bus.c:338:
qemu-system-ppc: Failed to create USB device 'usb-kbd'
Broken pipe
/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:129:
kill_qemu() detected QEMU death from signal 6 (Aborted) (core dumped)
FAIL
GTester: last random seed: R02Sb0415a974c001eb9b2bfd716d6d4daa0
(pid=27263)
FAIL: tests/boot-serial-test

and also in tests/qom-test and tests/test-hmp. i386 fails with:

TEST: tests/usb-hcd-ohci-test... (pid=28620)
  /i386/ohci/pci/init:                                                 OK
  /i386/ohci/pci/hotplug:                                              **
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:1142:qtest_qmp_device_add:
asse
rtion failed: (!qdict_haskey(response, "error"))
FAIL
GTester: last random seed: R02S5d5b0d2d059c51d15dad3c7e08343d0e
(pid=28632)
FAIL: tests/usb-hcd-ohci-test
TEST: tests/usb-hcd-uhci-test... (pid=28642)
qemu-system-i386: -device usb-tablet,bus=uhci.0,port=1: 'usb-tablet'
is not a valid device model name
Broken pipe
/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:121:
kill_qemu() tried to terminate QEMU process but encountered exit
status 1
FAIL: tests/usb-hcd-uhci-test
TEST: tests/usb-hcd-xhci-test... (pid=28655)
  /i386/xhci/pci/init:                                                 OK
  /i386/xhci/pci/hotplug:                                              **
ERROR:/home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:1142:qtest_qmp_device_add:
assertion failed: (!qdict_haskey(response, "error"))
FAIL
GTester: last random seed: R02S7ed3444ba55127a2283200a68c3f3ee5
(pid=28668)
  /i386/xhci/pci/hotplug/usb-uas:                                      OK
  /i386/xhci/pci/hotplug/usb-ccid:                                     OK
FAIL: tests/usb-hcd-xhci-test

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/6] Usb 20180917 patches

Posted by Gerd Hoffmann 7 years, 1 month ago

On Tue, Sep 25, 2018 at 11:05:29AM +0100, Peter Maydell wrote:
> On 17 September 2018 at 10:56, Gerd Hoffmann <kraxel@redhat.com> wrote:
> > The following changes since commit 19b599f7664b2ebfd0f405fb79c14dd241557452:
> >
> >   Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2018-08-27-v2' into staging (2018-08-27 16:44:20 +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.kraxel.org/qemu tags/usb-20180917-pull-request
> >
> > for you to fetch changes up to 5ef919130963ba478a65b1e559c71b876025cff7:
> >
> >   usb: assign unique serial numbers to hid devices (2018-09-17 11:54:26 +0200)
> >
> > ----------------------------------------------------------------
> > usb: bugfixes for mtp, hub and hid devices.
> >
> 
> Hi. This seems to fail 'make check' on x86-64 Linux host:
> 
> TEST: tests/qom-test... (pid=27321)
>   /sh4/qom/none:                                                       OK
>   /sh4/qom/shix:                                                       OK
>   /sh4/qom/r2d:
> Unexpected error in u
> sb_try_create_simple() at
> /home/petmay01/linaro/qemu-for-merges/hw/usb/bus.c:338:
> qemu-system-sh4: Failed to create USB device 'usb-kbd'
> Broken pipe
> /home/petmay01/linaro/qemu-for-merges/tests/libqtest.c:129:
> kill_qemu() detected QEMU death
> from signal 6 (Aborted) (core dumped)
> FAIL
> GTester: last random seed: R02S8e2f5918ab744c8a831cb30dc22eb415
> (pid=27435)
> FAIL: tests/qom-test
> TEST: tests/test-hmp... (pid=27445)

Hmm.  /me looks surprised.  Works fine for me, both the original pull
tag and the queue rebased to latest master.

Can you figure which patch causes this?  I'd guess the serial number
patch, even though I can't see yet how that one crashes qemu.

There is also the patch adding separate config options foe hub and hid
devices, which might cause usb-kbd not being compiled in, but qemu
should not dump core due to this ...

thanks,
  Gerd