migration cleanup fixes

[Qemu-devel] [PATCH 0/2] migration cleanup fixes

Posted by Dr. David Alan Gilbert (git) 7 years, 1 month ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

This is a pair of related migration fixes for cases where the loadvm
state doesn't get cleaned up.

In the first case this is because the code hasn't cleared the postcopy
flag, and so a following loadvm gets very confused (leading to it
not cleaning up the loadvm state or syncing the CPUs leading to no
interrupts and a very confused guest).

In the second case I just noticed a few return cases where it didn't get
cleaned up in error paths.

Dave


Dr. David Alan Gilbert (2):
  migration/postcopy: Clear have_listen_thread
  migration: cleanup in error paths in loadvm

 migration/savevm.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.17.1

Re: [Qemu-devel] [PATCH 0/2] migration cleanup fixes

Posted by Dr. David Alan Gilbert 7 years, 1 month ago

* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> This is a pair of related migration fixes for cases where the loadvm
> state doesn't get cleaned up.
> 
> In the first case this is because the code hasn't cleared the postcopy
> flag, and so a following loadvm gets very confused (leading to it
> not cleaning up the loadvm state or syncing the CPUs leading to no
> interrupts and a very confused guest).
> 
> In the second case I just noticed a few return cases where it didn't get
> cleaned up in error paths.
> 
> Dave

Queued.

> 
> Dr. David Alan Gilbert (2):
>   migration/postcopy: Clear have_listen_thread
>   migration: cleanup in error paths in loadvm
> 
>  migration/savevm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> -- 
> 2.17.1
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH 0/2] migration cleanup fixes

Posted by Peter Xu 7 years, 1 month ago

On Fri, Sep 14, 2018 at 06:04:28PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> This is a pair of related migration fixes for cases where the loadvm
> state doesn't get cleaned up.
> 
> In the first case this is because the code hasn't cleared the postcopy
> flag, and so a following loadvm gets very confused (leading to it
> not cleaning up the loadvm state or syncing the CPUs leading to no
> interrupts and a very confused guest).
> 
> In the second case I just noticed a few return cases where it didn't get
> cleaned up in error paths.

Reviewed-by: Peter Xu <peterx@redhat.com>

Regards,

-- 
Peter Xu