[Qemu-devel] [PATCH risu] ppc64.risu: Fix pattern for darn

Sandipan Das posted 1 patch 7 years, 2 months ago
Failed in applying to current master (apply log)
ppc64.risu | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH risu] ppc64.risu: Fix pattern for darn
Posted by Sandipan Das 7 years, 2 months ago
This fixes the pattern for the Deliver A Random Number (darn)
instruction to ensure that the value of the L field, which is
used to determine the type and length of the generated random
number, is never 3 which is currently reserved for future use.

Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
---
 ppc64.risu | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ppc64.risu b/ppc64.risu
index 2018103..a27e4fd 100644
--- a/ppc64.risu
+++ b/ppc64.risu
@@ -277,7 +277,7 @@ DADDQd PPC64LE 111111 frtp:5 frap:5 frbp:5 00000000101
 
 # format:X book:I page:79 v3.0 darn Deliver A Random Number
 DARN PPC64LE 011111 rt:5 000 l:2 0000010111100110 \
-!constraints { $rt != 1 && $rt != 13; }
+!constraints { $rt != 1 && $rt != 13 && $l != 3; }
 
 # format:X book:I page:217 v2.06 dcffix DFP Convert From Fixed
 DCFFIX PPC64LE 111011 frt:5 00000 frb:5 11001000100
-- 
2.14.4


Re: [Qemu-devel] [PATCH risu] ppc64.risu: Fix pattern for darn
Posted by Peter Maydell 7 years, 1 month ago
On 6 September 2018 at 07:51, Sandipan Das <sandipan@linux.ibm.com> wrote:
> This fixes the pattern for the Deliver A Random Number (darn)
> instruction to ensure that the value of the L field, which is
> used to determine the type and length of the generated random
> number, is never 3 which is currently reserved for future use.
>
> Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>
> ---
>  ppc64.risu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to risu master. My congratulations to the CPU architect
who managed to get that instruction mnemonic into the ISA :-)

thanks
-- PMM