[Qemu-devel] [PATCH v8 0/6] monitor: enable OOB by default

Peter Xu posted 6 patches 7 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180905062313.4059-1-peterx@redhat.com
Test checkpatch passed
Test docker-clang@ubuntu failed
There is a newer version of this series
docs/interop/qmp-spec.txt |  5 ++-
include/monitor/monitor.h |  3 +-
monitor.c                 | 80 +++++++++++++++------------------------
qapi/misc.json            | 40 --------------------
tests/libqtest.c          | 10 ++---
tests/libqtest.h          |  4 +-
tests/qmp-test.c          | 32 ++++++++++++++--
tests/test-qmp-cmds.c     | 16 ++++++++
vl.c                      |  5 ---
9 files changed, 86 insertions(+), 109 deletions(-)
[Qemu-devel] [PATCH v8 0/6] monitor: enable OOB by default
Posted by Peter Xu 7 years, 2 months ago
Based-on: <20180828191048.29806-1-armbru@redhat.com>
Based-on: <20180901111716.1675-1-armbru@redhat.com>

(this series is based on Markus's monitor-next tree)

v8:
- remove patch 1 & 2 since already in the QAPI pull
- squash patch 3 & 4, use Markus's version of commit message (with
  some of my additions), make sure popping and reading queue length is
  in the same critical section [Markus]
- add one patch to cover test for queue full [Markus]
- add one patch to resume the monitor earlier when queue not full [Markus]

v7:
- use Markus's commit message for patch "qapi: Drop
  qapi_event_send_FOO()'s Error ** argument" [Markus]
- update commit message for "qapi: remove COMMAND_DROPPED event" since
  QEMU 3.0 is released [Eric/Dave]
- rebase to Markus's monitor-next tree:
  http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/monitor-next
  the patch "monitor: suspend monitor instead of send CMD_DROP"
  re-written since people prefer to drop need_resume flag so now I
  hand-made it.  Dropped a few patches since not appliable any more.

Please review.  Thanks,

Peter Xu (6):
  monitor: Suspend monitor instead dropping commands
  monitor: resume the monitor earlier if needed
  monitor: remove "x-oob", turn oob on by default
  Revert "tests: Add parameter to qtest_init_without_qmp_handshake"
  tests: add oob functional test for test-qmp-cmds
  tests: qmp-test: add queue full test

 docs/interop/qmp-spec.txt |  5 ++-
 include/monitor/monitor.h |  3 +-
 monitor.c                 | 80 +++++++++++++++------------------------
 qapi/misc.json            | 40 --------------------
 tests/libqtest.c          | 10 ++---
 tests/libqtest.h          |  4 +-
 tests/qmp-test.c          | 32 ++++++++++++++--
 tests/test-qmp-cmds.c     | 16 ++++++++
 vl.c                      |  5 ---
 9 files changed, 86 insertions(+), 109 deletions(-)

-- 
2.17.1


Re: [Qemu-devel] [PATCH v8 0/6] monitor: enable OOB by default
Posted by Peter Xu 7 years, 1 month ago
On Wed, Sep 05, 2018 at 02:23:07PM +0800, Peter Xu wrote:
> Based-on: <20180828191048.29806-1-armbru@redhat.com>
> Based-on: <20180901111716.1675-1-armbru@redhat.com>
> 
> (this series is based on Markus's monitor-next tree)
> 
> v8:
> - remove patch 1 & 2 since already in the QAPI pull
> - squash patch 3 & 4, use Markus's version of commit message (with
>   some of my additions), make sure popping and reading queue length is
>   in the same critical section [Markus]
> - add one patch to cover test for queue full [Markus]
> - add one patch to resume the monitor earlier when queue not full [Markus]
> 
> v7:
> - use Markus's commit message for patch "qapi: Drop
>   qapi_event_send_FOO()'s Error ** argument" [Markus]
> - update commit message for "qapi: remove COMMAND_DROPPED event" since
>   QEMU 3.0 is released [Eric/Dave]
> - rebase to Markus's monitor-next tree:
>   http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/monitor-next
>   the patch "monitor: suspend monitor instead of send CMD_DROP"
>   re-written since people prefer to drop need_resume flag so now I
>   hand-made it.  Dropped a few patches since not appliable any more.
> 
> Please review.  Thanks,

Ping?

Regards,

-- 
Peter Xu

Re: [Qemu-devel] [PATCH v8 0/6] monitor: enable OOB by default
Posted by Markus Armbruster 7 years, 1 month ago
Peter Xu <peterx@redhat.com> writes:

> On Wed, Sep 05, 2018 at 02:23:07PM +0800, Peter Xu wrote:
>> Based-on: <20180828191048.29806-1-armbru@redhat.com>
>> Based-on: <20180901111716.1675-1-armbru@redhat.com>
>> 
>> (this series is based on Markus's monitor-next tree)
>> 
>> v8:
>> - remove patch 1 & 2 since already in the QAPI pull
>> - squash patch 3 & 4, use Markus's version of commit message (with
>>   some of my additions), make sure popping and reading queue length is
>>   in the same critical section [Markus]
>> - add one patch to cover test for queue full [Markus]
>> - add one patch to resume the monitor earlier when queue not full [Markus]
>> 
>> v7:
>> - use Markus's commit message for patch "qapi: Drop
>>   qapi_event_send_FOO()'s Error ** argument" [Markus]
>> - update commit message for "qapi: remove COMMAND_DROPPED event" since
>>   QEMU 3.0 is released [Eric/Dave]
>> - rebase to Markus's monitor-next tree:
>>   http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/monitor-next
>>   the patch "monitor: suspend monitor instead of send CMD_DROP"
>>   re-written since people prefer to drop need_resume flag so now I
>>   hand-made it.  Dropped a few patches since not appliable any more.
>> 
>> Please review.  Thanks,
>
> Ping?

It's in my review queue.  Thanks for the reminder.