[v5] Some improvements in z/Arch instructions support

[Qemu-devel] [PATCH v5 0/3] Some improvements in z/Arch instructions support

Pavel Zbitskiy posted 3 patches 7 years, 2 months ago

Diff against v1 v1 v1 v1 v4
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180902003322.3428-1-pavel.zbitskiy@gmail.com

Test docker-clang@ubuntu failed

Test checkpatch passed

target/s390x/helper.h           |  1 +
target/s390x/insn-data.def      |  4 +++
target/s390x/int_helper.c       | 52 +++++++++++++++++++++++++++++++++
target/s390x/translate.c        | 21 ++++++++++---
tests/tcg/s390x/Makefile.target |  1 +
tests/tcg/s390x/cvb.c           | 18 ++++++++++++
6 files changed, 93 insertions(+), 4 deletions(-)
create mode 100644 tests/tcg/s390x/cvb.c

Expand all Fold all

[Qemu-devel] [PATCH v5 0/3] Some improvements in z/Arch instructions support

Posted by Pavel Zbitskiy 7 years, 2 months ago

Changes since v4:

* Simplified alignment checks by using tcg_gen_qemu_ld_i64 and
  MO_ALIGN*.

Pavel Zbitskiy (3):
  target/s390x: use regular spaces in translate.c
  target/s390x: exception on non-aligned LPSW(E)
  target/s390x: implement CVB, CVBY and CVBG

 target/s390x/helper.h           |  1 +
 target/s390x/insn-data.def      |  4 +++
 target/s390x/int_helper.c       | 52 +++++++++++++++++++++++++++++++++
 target/s390x/translate.c        | 21 ++++++++++---
 tests/tcg/s390x/Makefile.target |  1 +
 tests/tcg/s390x/cvb.c           | 18 ++++++++++++
 6 files changed, 93 insertions(+), 4 deletions(-)
 create mode 100644 tests/tcg/s390x/cvb.c

-- 
2.18.0

Re: [Qemu-devel] [PATCH v5 0/3] Some improvements in z/Arch instructions support

Posted by David Hildenbrand 7 years, 2 months ago

On 02.09.2018 02:33, Pavel Zbitskiy wrote:
> Changes since v4:
> 
> * Simplified alignment checks by using tcg_gen_qemu_ld_i64 and
>   MO_ALIGN*.
> 
> Pavel Zbitskiy (3):
>   target/s390x: use regular spaces in translate.c
>   target/s390x: exception on non-aligned LPSW(E)
>   target/s390x: implement CVB, CVBY and CVBG
> 
>  target/s390x/helper.h           |  1 +
>  target/s390x/insn-data.def      |  4 +++
>  target/s390x/int_helper.c       | 52 +++++++++++++++++++++++++++++++++
>  target/s390x/translate.c        | 21 ++++++++++---
>  tests/tcg/s390x/Makefile.target |  1 +
>  tests/tcg/s390x/cvb.c           | 18 ++++++++++++
>  6 files changed, 93 insertions(+), 4 deletions(-)
>  create mode 100644 tests/tcg/s390x/cvb.c
> 

Hi Pavel,

I'm leaving for vacation tomorrow and will have a look in two weeks when
I'm back. Also, Conny is on vacation, so expect ~2 weeks until this gets
reviewed / picked up.

Thanks!

-- 

Thanks,

David / dhildenb