[Qemu-devel] [PATCH v2 0/2] qemu-error: advanced report_once handling

Cornelia Huck posted 2 patches 7 years, 2 months ago
Failed in applying to current master (apply log)
hw/vfio/ccw.c               | 18 +++--------------
include/qemu/error-report.h | 39 ++++++++++++++++++------------------
util/qemu-error.c           | 48 +++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 70 insertions(+), 35 deletions(-)
[Qemu-devel] [PATCH v2 0/2] qemu-error: advanced report_once handling
Posted by Cornelia Huck 7 years, 2 months ago
[Markus: I've decided to not include your R-b, as I did too many changes
to feel comfortable with that.]

[Also note that I'm about to disappear on vacation, so don't expect
quick responses. I just want to get it out before I forget about it.]

Based on previous discussions, I wanted to enhance the recently
merged report_once infrastucture with a way to print a message
once based on a variable instead of globally-once, similar to
what vfio-ccw uses today.

Not really tested, mainly wanted to get this out before my vacation
to get the ball rolling.

v1->v2:
- merged patch 3 (use the new function in vfio-ccw) into patch 1
- require a non-NULL 'printed' parameter
- have the functions return whether something was printed and slightly
  simplify the existing macros
- adapt macro formatting to suit my aesthetic sensibilities

Cornelia Huck (2):
  qemu-error: add {error,warn}_report_once_cond
  qemu-error: make use of {error,warn}_report_once_cond

 hw/vfio/ccw.c               | 18 +++--------------
 include/qemu/error-report.h | 39 ++++++++++++++++++------------------
 util/qemu-error.c           | 48 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 70 insertions(+), 35 deletions(-)

-- 
2.14.4


Re: [Qemu-devel] [PATCH v2 0/2] qemu-error: advanced report_once handling
Posted by Markus Armbruster 7 years, 1 month ago
Cornelia Huck <cohuck@redhat.com> writes:

> [Markus: I've decided to not include your R-b, as I did too many changes
> to feel comfortable with that.]
>
> [Also note that I'm about to disappear on vacation, so don't expect
> quick responses. I just want to get it out before I forget about it.]
>
> Based on previous discussions, I wanted to enhance the recently
> merged report_once infrastucture with a way to print a message
> once based on a variable instead of globally-once, similar to
> what vfio-ccw uses today.
>
> Not really tested, mainly wanted to get this out before my vacation
> to get the ball rolling.

Queued, thanks!