[Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes

Marc-André Lureau posted 10 patches 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180829134043.31706-1-marcandre.lureau@redhat.com
Test docker-clang@ubuntu failed
Test checkpatch passed
include/qapi/qmp/dispatch.h             |   2 +-
monitor.c                               | 170 +++---------------------
qapi/qmp-dispatch.c                     |  12 +-
qga/main.c                              |  57 +++-----
qobject/json-lexer.c                    |   5 +-
tests/qmp-cmd-test.c                    |  31 +++++
tests/qmp-test.c                        |  18 +++
tests/test-qga.c                        |  13 +-
tests/test-qmp-cmds.c                   |  17 +++
tests/qapi-schema/qapi-schema-test.json |   2 +
tests/qapi-schema/qapi-schema-test.out  |   2 +
11 files changed, 125 insertions(+), 204 deletions(-)
[Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes
Posted by Marc-André Lureau 5 years, 8 months ago
Hi,

This series is a rebased subset of "[PATCH v3 00/38] RFC: monitor: add
asynchronous command type".

v4:
- splitted "tests: add a few qmp tests"
- fix success-response crash regression in "qga: process_event() simplification"
- add r-b tags from Michael

v3:
- updated "tests: add a few qmp tests" to move tests to new files
- comment update in "qmp: common 'id' handling & make QGA conform to QMP spec"
- commit message updates, add r-b tags

Marc-André Lureau (10):
  monitor: consitify qmp_send_response() QDict argument
  qmp: constify qmp_is_oob()
  Revert "qmp: isolate responses into io thread"
  monitor: no need to save need_resume
  json-lexer: make it safe to call destroy multiple times
  tests: add qmp/object-add-without-props test
  tests: add qmp/qom-set-without-value test
  tests: add a qmp success-response test
  qga: process_event() simplification
  qmp: common 'id' handling & make QGA conform to QMP spec

 include/qapi/qmp/dispatch.h             |   2 +-
 monitor.c                               | 170 +++---------------------
 qapi/qmp-dispatch.c                     |  12 +-
 qga/main.c                              |  57 +++-----
 qobject/json-lexer.c                    |   5 +-
 tests/qmp-cmd-test.c                    |  31 +++++
 tests/qmp-test.c                        |  18 +++
 tests/test-qga.c                        |  13 +-
 tests/test-qmp-cmds.c                   |  17 +++
 tests/qapi-schema/qapi-schema-test.json |   2 +
 tests/qapi-schema/qapi-schema-test.out  |   2 +
 11 files changed, 125 insertions(+), 204 deletions(-)

-- 
2.19.0.rc0.48.gb9dfa238d5


Re: [Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes
Posted by Markus Armbruster 5 years, 8 months ago
Marc-André Lureau <marcandre.lureau@redhat.com> writes:

> Hi,
>
> This series is a rebased subset of "[PATCH v3 00/38] RFC: monitor: add
> asynchronous command type".

PATCH 01-04 are core monitor work Peter will need to make progress.
Queued.
http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/monitor-next

PATCH 05 I'd like you to keep in your qmp-async series.

PATCH 06-07 could use a bit of work.

PATCH 08-10 are related to QGA.  Michael, would you like me to handle
them?

Re: [Qemu-devel] [PATCH v4 00/10] monitor: various code simplification and fixes
Posted by Michael Roth 5 years, 8 months ago
Quoting Markus Armbruster (2018-08-30 09:21:11)
> Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> 
> > Hi,
> >
> > This series is a rebased subset of "[PATCH v3 00/38] RFC: monitor: add
> > asynchronous command type".
> 
> PATCH 01-04 are core monitor work Peter will need to make progress.
> Queued.
> http://repo.or.cz/qemu/armbru.git/shortlog/refs/heads/monitor-next
> 
> PATCH 05 I'd like you to keep in your qmp-async series.
> 
> PATCH 06-07 could use a bit of work.
> 
> PATCH 08-10 are related to QGA.  Michael, would you like me to handle
> them?

That's fine by me, can take them through my tree too if you'd prefer,
just let me know.