[v1] Error reporting patches for 2018-08-27

[Qemu-devel] [PULL 0/3] Error reporting patches for 2018-08-27

Markus Armbruster posted 3 patches 7 years, 2 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180827060744.13770-1-armbru@redhat.com

Test docker-clang@ubuntu failed

Test checkpatch passed

There is a newer version of this series

hw/i386/intel_iommu.c       | 127 ++++++++++++++++++++++++++++----------------
hw/i386/trace-events        |  13 -----
include/qemu/error-report.h |  32 +++++++++++
3 files changed, 113 insertions(+), 59 deletions(-)

Expand all Fold all

[Qemu-devel] [PULL 0/3] Error reporting patches for 2018-08-27

Posted by Markus Armbruster 7 years, 2 months ago

The following changes since commit 235c82acca0491465e94be3cae2583b42d37c859:

  Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180823' into staging (2018-08-25 13:08:57 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-error-2018-08-27

for you to fetch changes up to d111ed70a7d0357dfe92548768751a2b9fadacbc:

  intel-iommu: replace more vtd_err_* traces (2018-08-27 06:38:45 +0200)

----------------------------------------------------------------
Error reporting patches for 2018-08-27

* Provide error_report_once(), along with first users

----------------------------------------------------------------
Peter Xu (3):
      qemu-error: introduce {error|warn}_report_once
      intel-iommu: start to use error_report_once
      intel-iommu: replace more vtd_err_* traces

 hw/i386/intel_iommu.c       | 127 ++++++++++++++++++++++++++++----------------
 hw/i386/trace-events        |  13 -----
 include/qemu/error-report.h |  32 +++++++++++
 3 files changed, 113 insertions(+), 59 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PULL 0/3] Error reporting patches for 2018-08-27

Posted by Peter Maydell 7 years, 2 months ago

On 27 August 2018 at 07:07, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 235c82acca0491465e94be3cae2583b42d37c859:
>
>   Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-20180823' into staging (2018-08-25 13:08:57 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-error-2018-08-27
>
> for you to fetch changes up to d111ed70a7d0357dfe92548768751a2b9fadacbc:
>
>   intel-iommu: replace more vtd_err_* traces (2018-08-27 06:38:45 +0200)
>
> ----------------------------------------------------------------
> Error reporting patches for 2018-08-27
>
> * Provide error_report_once(), along with first users
>
> ----------------------------------------------------------------

Compile failure on OSX:

/Users/pm215/src/qemu-for-merges/hw/i386/intel_iommu.c:1069:31: error:
format specifies type 'unsigned short' but the argument has type 'int'
[-Werror,-Wformat]
                              pci_bus_num(vtd_as->bus), vtd_as->devfn);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/include/qemu/error-report.h:58:33:
note: expanded from macro 'error_report_once'
            error_report(fmt, ##__VA_ARGS__);   \
                                ^~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/hw/i386/intel_iommu.c:1069:57: error:
format specifies type 'unsigned short' but the argument has type
'uint8_t' (aka 'unsigned char') [-Werror,-Wformat]
                              pci_bus_num(vtd_as->bus), vtd_as->devfn);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/Users/pm215/src/qemu-for-merges/include/qemu/error-report.h:58:33:
note: expanded from macro 'error_report_once'
            error_report(fmt, ##__VA_ARGS__);   \
                                ^~~~~~~~~~~
2 errors generated.


thanks
-- PMM