Hi; this patchset removes support for the old_mmio accessors
from the memory core code, now that we have fixed all the
devices that were using it.

Patch 1 does that removal.
Patch 2 fixes up a wart in fw_cfg that was only needed while
we had the old_mmio accessors (spotted because of the comment
coming up in my grep for 'old_mmio'...)
Patch 3 is a bonus that adds documentation for the _with_attrs
accessors, since I noticed while writing patch 1 that we
hadn't actually written any.

Based-on: <20180802174042.29234-1-peter.maydell@linaro.org>
("[PATCH 0/2] hw/net/pcnet-pci: Convert away from old_mmio accessors")

The pcnet-pci patches are the only "convert away from old_mmio"
patches still not yet in master; they've been reviewed, they just
haven't been picked up by anybody yet.

thanks
-- PMM

Peter Maydell (3):
  memory: Remove old_mmio accessors
  hw/nvram/fw_cfg: Use memberwise copy of MemoryRegionOps struct
  docs/devel/memory.txt: Document _with_attrs accessors

 docs/devel/memory.txt | 13 ++++++---
 include/exec/memory.h |  5 ----
 hw/nvram/fw_cfg.c     |  7 +----
 memory.c              | 64 ++-----------------------------------------
 4 files changed, 12 insertions(+), 77 deletions(-)

-- 
2.18.0

On 24 August 2018 at 18:04, Peter Maydell <peter.maydell@linaro.org> wrote:
> Hi; this patchset removes support for the old_mmio accessors
> from the memory core code, now that we have fixed all the
> devices that were using it.
>
> Patch 1 does that removal.
> Patch 2 fixes up a wart in fw_cfg that was only needed while
> we had the old_mmio accessors (spotted because of the comment
> coming up in my grep for 'old_mmio'...)
> Patch 3 is a bonus that adds documentation for the _with_attrs
> accessors, since I noticed while writing patch 1 that we
> hadn't actually written any.
>
> Based-on: <20180802174042.29234-1-peter.maydell@linaro.org>
> ("[PATCH 0/2] hw/net/pcnet-pci: Convert away from old_mmio accessors")
>
> The pcnet-pci patches are the only "convert away from old_mmio"
> patches still not yet in master; they've been reviewed, they just
> haven't been picked up by anybody yet.

The pcnet-pci patches are now in master, so the prerequisites
for this series are all now met. Patches 1 and 2 have been
reviewed, so I think we just want review for the docs patch 3.

Paolo, I'm assuming you want to take these patches via the
memory tree ?

thanks
-- PMM

On 25/09/2018 16:52, Peter Maydell wrote:
> 
> Paolo, I'm assuming you want to take these patches via the
> memory tree ?

Yes, I can do that (I'll send the pull request either on Saturday or
Monday).

Paolo