[Qemu-devel] [PATCH v4 3/4] configure: require libseccomp 2.2.0

Marc-André Lureau posted 4 patches 7 years, 2 months ago
[Qemu-devel] [PATCH v4 3/4] configure: require libseccomp 2.2.0
Posted by Marc-André Lureau 7 years, 2 months ago
The following patch is going to require TSYNC, which is only available
since libseccomp 2.2.0.

libseccomp 2.2.0 was released February 12, 2015.

According to repology, libseccomp version in different distros:

  RHEL-7: 2.3.1
  Debian (Stretch): 2.3.1
  OpenSUSE Leap 15: 2.3.2
  Ubuntu (Xenial):  2.3.1

This will drop support for -sandbox on:

  Debian (Jessie): 2.1.1 (but 2.2.3 in backports)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 configure | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/configure b/configure
index e7bddc04b0..5fc2915096 100755
--- a/configure
+++ b/configure
@@ -2228,13 +2228,10 @@ fi
 ##########################################
 # libseccomp check
 
+libseccomp_minver="2.2.0"
 if test "$seccomp" != "no" ; then
     case "$cpu" in
-    i386|x86_64)
-        libseccomp_minver="2.1.0"
-        ;;
-    mips)
-        libseccomp_minver="2.2.0"
+    i386|x86_64|mips)
         ;;
     arm|aarch64)
         libseccomp_minver="2.2.3"
-- 
2.18.0.547.g1d89318c48


Re: [Qemu-devel] [PATCH v4 3/4] configure: require libseccomp 2.2.0
Posted by Daniel P. Berrangé 7 years, 2 months ago
On Wed, Aug 22, 2018 at 07:02:49PM +0200, Marc-André Lureau wrote:
> The following patch is going to require TSYNC, which is only available
> since libseccomp 2.2.0.
> 
> libseccomp 2.2.0 was released February 12, 2015.
> 
> According to repology, libseccomp version in different distros:
> 
>   RHEL-7: 2.3.1
>   Debian (Stretch): 2.3.1
>   OpenSUSE Leap 15: 2.3.2
>   Ubuntu (Xenial):  2.3.1
> 
> This will drop support for -sandbox on:
> 
>   Debian (Jessie): 2.1.1 (but 2.2.3 in backports)
>

Diverging slightly from our normal distro target set, but
acceptable given that this is a security feature which is
impossible to correctly implement with older versions.

> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  configure | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|