[Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files

Juan Quintela posted 10 patches 7 years, 2 months ago
[Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files
Posted by Juan Quintela 7 years, 2 months ago
If you don't want to compile everything, you configure
config-devices.mak.  And then make clean remove it, and make will
create a default one without your configuration.  Fix it by not
removing it on clean target.  Remove it instead on distclean.

Signed-off-by: Juan Quintela <quintela@redhat.com>

--

Remove it instead on distclean.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b7c6e57de6..fe623e4634 100644
--- a/Makefile
+++ b/Makefile
@@ -752,7 +752,7 @@ clean:
 	if test -d $$d; then $(MAKE) -C $$d $@ || exit 1; fi; \
 	rm -f $$d/qemu-options.def; \
         done
-	rm -f $(SUBDIR_DEVICES_MAK) config-all-devices.mak
+	rm -f config-all-devices.mak
 
 VERSION ?= $(shell cat VERSION)
 
@@ -764,6 +764,7 @@ qemu-%.tar.bz2:
 distclean: clean
 	rm -f config-host.mak config-host.h* config-host.ld $(DOCS) qemu-options.texi qemu-img-cmds.texi qemu-monitor.texi qemu-monitor-info.texi
 	rm -f config-all-devices.mak config-all-disas.mak config.status
+	rm -f $(SUBDIR_DEVICES_MAK)
 	rm -f po/*.mo tests/qemu-iotests/common.env
 	rm -f roms/seabios/config.mak roms/vgabios/config.mak
 	rm -f qemu-doc.info qemu-doc.aux qemu-doc.cp qemu-doc.cps
-- 
2.17.1


Re: [Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files
Posted by Thomas Huth 7 years, 2 months ago
On 2018-08-22 11:54, Juan Quintela wrote:
> If you don't want to compile everything, you configure
> config-devices.mak.  And then make clean remove it, and make will
> create a default one without your configuration.  Fix it by not
> removing it on clean target.  Remove it instead on distclean.

Sounds like a good idea!

> Signed-off-by: Juan Quintela <quintela@redhat.com>
> 
> --
> 
> Remove it instead on distclean.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Please remove the duplicated Sob. Then you can add:

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files
Posted by Juan Quintela 7 years, 2 months ago
Thomas Huth <thuth@redhat.com> wrote:
> On 2018-08-22 11:54, Juan Quintela wrote:
>> If you don't want to compile everything, you configure
>> config-devices.mak.  And then make clean remove it, and make will
>> create a default one without your configuration.  Fix it by not
>> removing it on clean target.  Remove it instead on distclean.
>
> Sounds like a good idea!
>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> 
>> --
>> 
>> Remove it instead on distclean.
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> Please remove the duplicated Sob. Then you can add:

Done, thanks.

> Reviewed-by: Thomas Huth <thuth@redhat.com>