[Qemu-devel] [PATCH 0/3] Detabify target/arm

Peter Maydell posted 3 patches 7 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180821165215.29069-1-peter.maydell@linaro.org
Test docker-clang@ubuntu failed
Test checkpatch passed
target/arm/cpu.h           |  16 +--
target/arm/arm-semi.c      |   2 +-
target/arm/iwmmxt_helper.c | 234 ++++++++++++++++++-------------------
target/arm/translate.c     | 122 +++++++++----------
4 files changed, 187 insertions(+), 187 deletions(-)
[Qemu-devel] [PATCH 0/3] Detabify target/arm
Posted by Peter Maydell 7 years, 2 months ago
This patchset removes hardcoded tabs from target/arm.

Normally we're generally against patches which only do style
fixups, preferring to fix up code as we need to touch it.
But in this case, almost all of the tabs are in the old
iwMMXt instruction set handling, which we have not needed
to touch in years, so the "fix as we touch it" process isn't
going to adjust them. Also, since they're changes to
barely-touched code they're not going to cause conflicts with
other work-in-progress in that area or be likely to result in
future pain trying to do stable backports of bugfixes.
So I think it's reasonable to do a bulk fixup in this case,
especially for translate.c, which is a file that sees active
development in other parts of the same file.

This isn't intended to announce an open season for
coding style fixup patches -- that is up to the individual
submaintainer and should not be done unsolicited.

thanks
-- PMM

Peter Maydell (3):
  target/arm: Untabify translate.c
  target/arm: Untabify iwmmxt_helper.c
  target/arm: Remove a handful of stray tabs

 target/arm/cpu.h           |  16 +--
 target/arm/arm-semi.c      |   2 +-
 target/arm/iwmmxt_helper.c | 234 ++++++++++++++++++-------------------
 target/arm/translate.c     | 122 +++++++++----------
 4 files changed, 187 insertions(+), 187 deletions(-)

-- 
2.18.0