Drop obsolete memory system request_ptr API

[Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

Peter Maydell posted 3 patches 7 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180817114619.22354-1-peter.maydell@linaro.org

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

hw/misc/Makefile.objs            |   1 -
include/exec/memory.h            |  35 --------
include/hw/misc/mmio_interface.h |  49 -----------
hw/misc/mmio_interface.c         | 135 -------------------------------
hw/ssi/xilinx_spips.c            |  46 -----------
memory.c                         | 110 -------------------------
6 files changed, 376 deletions(-)
delete mode 100644 include/hw/misc/mmio_interface.h
delete mode 100644 hw/misc/mmio_interface.c

Expand all Fold all

[Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

Posted by Peter Maydell 7 years, 2 months ago

Now that support has hit master for direct execution from
arbitrary MMIO regions, we can remove the MMIO request_ptr
API, which required special case support in each device that
wanted to handle it, and also had bad race conditions that
resulted in crashes if you tried to use it heavily.

This API was only ever used in one device in the source
tree, the Xilinx SPIPS. These three patches remove the
now-unneeded code from the Xilinx device and then the
core memory subsystem code.

thanks
-- PMM

Peter Maydell (3):
  hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code
  memory: Remove MMIO request_ptr APIs
  hw/misc: Remove mmio_interface device

 hw/misc/Makefile.objs            |   1 -
 include/exec/memory.h            |  35 --------
 include/hw/misc/mmio_interface.h |  49 -----------
 hw/misc/mmio_interface.c         | 135 -------------------------------
 hw/ssi/xilinx_spips.c            |  46 -----------
 memory.c                         | 110 -------------------------
 6 files changed, 376 deletions(-)
 delete mode 100644 include/hw/misc/mmio_interface.h
 delete mode 100644 hw/misc/mmio_interface.c

-- 
2.18.0

Re: [Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

Posted by Paolo Bonzini 7 years, 2 months ago

On 17/08/2018 13:46, Peter Maydell wrote:
> Now that support has hit master for direct execution from
> arbitrary MMIO regions, we can remove the MMIO request_ptr
> API, which required special case support in each device that
> wanted to handle it, and also had bad race conditions that
> resulted in crashes if you tried to use it heavily.
> 
> This API was only ever used in one device in the source
> tree, the Xilinx SPIPS. These three patches remove the
> now-unneeded code from the Xilinx device and then the
> core memory subsystem code.
> 
> thanks
> -- PMM
> 
> Peter Maydell (3):
>   hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code
>   memory: Remove MMIO request_ptr APIs
>   hw/misc: Remove mmio_interface device
> 
>  hw/misc/Makefile.objs            |   1 -
>  include/exec/memory.h            |  35 --------
>  include/hw/misc/mmio_interface.h |  49 -----------
>  hw/misc/mmio_interface.c         | 135 -------------------------------
>  hw/ssi/xilinx_spips.c            |  46 -----------
>  memory.c                         | 110 -------------------------
>  6 files changed, 376 deletions(-)
>  delete mode 100644 include/hw/misc/mmio_interface.h
>  delete mode 100644 hw/misc/mmio_interface.c
> 

The diffstat speaks for itself, go ahead and include it via the ARM tree.

Thanks,

Paolo

Re: [Qemu-devel] [PATCH 0/3] Drop obsolete memory system request_ptr API

Posted by Edgar E. Iglesias 7 years, 2 months ago

On Fri, Aug 17, 2018 at 12:46:16PM +0100, Peter Maydell wrote:
> Now that support has hit master for direct execution from
> arbitrary MMIO regions, we can remove the MMIO request_ptr
> API, which required special case support in each device that
> wanted to handle it, and also had bad race conditions that
> resulted in crashes if you tried to use it heavily.
> 
> This API was only ever used in one device in the source
> tree, the Xilinx SPIPS. These three patches remove the
> now-unneeded code from the Xilinx device and then the
> core memory subsystem code.


Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> 
> thanks
> -- PMM
> 
> Peter Maydell (3):
>   hw/ssi/xilinx_spips: Remove unneeded MMIO request_ptr code
>   memory: Remove MMIO request_ptr APIs
>   hw/misc: Remove mmio_interface device
> 
>  hw/misc/Makefile.objs            |   1 -
>  include/exec/memory.h            |  35 --------
>  include/hw/misc/mmio_interface.h |  49 -----------
>  hw/misc/mmio_interface.c         | 135 -------------------------------
>  hw/ssi/xilinx_spips.c            |  46 -----------
>  memory.c                         | 110 -------------------------
>  6 files changed, 376 deletions(-)
>  delete mode 100644 include/hw/misc/mmio_interface.h
>  delete mode 100644 hw/misc/mmio_interface.c
> 
> -- 
> 2.18.0
>