[Qemu-devel] [PATCH v5 0/3] arm: Add nRF51 SoC and micro:bit machine

Joel Stanley posted 3 patches 5 years, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
MAINTAINERS                     |   8 +++
default-configs/arm-softmmu.mak |   1 +
hw/arm/Makefile.objs            |   1 +
hw/arm/microbit.c               |  54 +++++++++++++++
hw/arm/nrf51_soc.c              | 119 ++++++++++++++++++++++++++++++++
include/hw/arm/nrf51_soc.h      |  42 +++++++++++
6 files changed, 225 insertions(+)
create mode 100644 hw/arm/microbit.c
create mode 100644 hw/arm/nrf51_soc.c
create mode 100644 include/hw/arm/nrf51_soc.h
[Qemu-devel] [PATCH v5 0/3] arm: Add nRF51 SoC and micro:bit machine
Posted by Joel Stanley 5 years, 8 months ago
v5: Change back to ARMv7M from ARMMProfile
v4: Fix number of IRQs
v3: Rebase on Stefan's cortex-m0 series
v2: Addresses review from Peter and Stefan

Based-on: 20180814162739.11814-1-stefanha@redhat.com

This short series implements a minimal definition of the Nordic
Semiconductor nRF51, a Cortex-M0 ARM SoC, and the BBC micro:bit, a
machine that will use this SoC.

This work will serve as the base for our Google Summer of Code and
Outreachy interns who will work on implementing a number of features on
top of this base.

I've tested this with a microbit micropython firmware, and checked that
it starts running by looking at it with gdb.

I chose to keep the nrf51 and the microbit seperate, to not confuse the
peripherals that are on the microbit but are not part of the nrf51, and
vice versa.


Joel Stanley (3):
  MAINTAINERS: Add NRF51 entry
  arm: Add Nordic Semiconductor nRF51 SoC
  arm: Add BBC micro:bit machine

 MAINTAINERS                     |   8 +++
 default-configs/arm-softmmu.mak |   1 +
 hw/arm/Makefile.objs            |   1 +
 hw/arm/microbit.c               |  54 +++++++++++++++
 hw/arm/nrf51_soc.c              | 119 ++++++++++++++++++++++++++++++++
 include/hw/arm/nrf51_soc.h      |  42 +++++++++++
 6 files changed, 225 insertions(+)
 create mode 100644 hw/arm/microbit.c
 create mode 100644 hw/arm/nrf51_soc.c
 create mode 100644 include/hw/arm/nrf51_soc.h

-- 
2.17.1


Re: [Qemu-devel] [PATCH v5 0/3] arm: Add nRF51 SoC and micro:bit machine
Posted by Peter Maydell 5 years, 8 months ago
On 16 August 2018 at 15:13, Joel Stanley <joel@jms.id.au> wrote:
> v5: Change back to ARMv7M from ARMMProfile
> v4: Fix number of IRQs
> v3: Rebase on Stefan's cortex-m0 series
> v2: Addresses review from Peter and Stefan
>
> Based-on: 20180814162739.11814-1-stefanha@redhat.com
>
> This short series implements a minimal definition of the Nordic
> Semiconductor nRF51, a Cortex-M0 ARM SoC, and the BBC micro:bit, a
> machine that will use this SoC.

Hi Joel; it looks like my review of v4 crossed in the mail
with your sending out v5. I think that my comments on
the v4 patch 3 still applies to v5, though (as does my
reviwed-by tag on patch 1).

thanks
-- PMM