On 13/08/2018 13:15, Michael S. Tsirkin wrote:
> On Mon, Aug 13, 2018 at 12:14:53PM +0200, Emanuele Giuseppe Esposito wrote:
>> vhost-user-test has not converted to qgraph yet, and since
>> it uses virtio interface, it won't work, causing make check
>> to fail.
>> Commented out until it does not get converted to graph node.
>>
>> Signed-off-by: Emanuele Giuseppe Esposito <e.emanuelegiuseppe@gmail.com>
>
> Two problems with that
> - we lose vhost user coverage
> - bisecting to before patch 33 will leave us with
> a failing make check
See $SUBJECT, "temporarily". :)
Paolo
>
>> ---
>> tests/Makefile.include | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 15926cc95f..30355058fc 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -287,10 +287,10 @@ check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>> check-qtest-i386-y += tests/q35-test$(EXESUF)
>> check-qtest-i386-y += tests/vmgenid-test$(EXESUF)
>> gcov-files-i386-y += hw/pci-host/q35.c
>> -check-qtest-i386-$(CONFIG_VHOST_USER_NET_TEST_i386) += tests/vhost-user-test$(EXESUF)
>> -ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)
>> -check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) += tests/vhost-user-test$(EXESUF)
>> -endif
>> +# check-qtest-i386-$(CONFIG_VHOST_USER_NET_TEST_i386) += tests/vhost-user-test$(EXESUF)
>> +# ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)
>> +# check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) += tests/vhost-user-test$(EXESUF)
>> +# endif
>> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-crb-swtpm-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-crb-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-tis-swtpm-test$(EXESUF)
>> --
>> 2.17.1