[Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support

Steffen Görtz posted 7 patches 5 years, 8 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180806100114.21410-1-contrib@steffen-goertz.de
Test checkpatch passed
Test docker-mingw@fedora failed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 failed
There is a newer version of this series
Makefile.objs                   |   1 +
hw/display/Makefile.objs        |   2 +
hw/display/led_matrix.c         | 262 +++++++++++++++++++++
hw/gpio/Makefile.objs           |   1 +
hw/gpio/nrf51_gpio.c            | 305 +++++++++++++++++++++++++
hw/gpio/trace-events            |   7 +
hw/misc/Makefile.objs           |   1 +
hw/misc/nrf51_rng.c             | 273 ++++++++++++++++++++++
hw/nvram/Makefile.objs          |   1 +
hw/nvram/nrf51_nvm.c            | 390 ++++++++++++++++++++++++++++++++
hw/timer/Makefile.objs          |   1 +
hw/timer/nrf51_timer.c          | 382 +++++++++++++++++++++++++++++++
hw/timer/trace-events           |   5 +
include/hw/display/led_matrix.h |  38 ++++
include/hw/gpio/nrf51_gpio.h    |  57 +++++
include/hw/misc/nrf51_rng.h     |  71 ++++++
include/hw/nvram/nrf51_nvm.h    |  56 +++++
include/hw/timer/nrf51_timer.h  |  63 ++++++
tests/Makefile.include          |   2 +
tests/microbit-test.c           | 222 ++++++++++++++++++
20 files changed, 2140 insertions(+)
create mode 100644 hw/display/led_matrix.c
create mode 100644 hw/gpio/nrf51_gpio.c
create mode 100644 hw/gpio/trace-events
create mode 100644 hw/misc/nrf51_rng.c
create mode 100644 hw/nvram/nrf51_nvm.c
create mode 100644 hw/timer/nrf51_timer.c
create mode 100644 include/hw/display/led_matrix.h
create mode 100644 include/hw/gpio/nrf51_gpio.h
create mode 100644 include/hw/misc/nrf51_rng.h
create mode 100644 include/hw/nvram/nrf51_nvm.h
create mode 100644 include/hw/timer/nrf51_timer.h
create mode 100644 tests/microbit-test.c
[Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support
Posted by Steffen Görtz 5 years, 8 months ago
This series contains additional peripheral devices for the nRF51822
microcontroller. Furthermore it includes a device to demultiplex
the row and column strobes used in embedded devices to drive
2D LED dot-matrices.

Included devices:
- Random Number Generator
- Non-volatile Memories
- General purpose I/O
- Timer 

Microbit board-level Devices:
- LED Matrix

Instantiate of the devices is done in an upcoming patch series.

Based-on: 20180726023645.13927-1-joel@jms.id.au

Steffen Görtz (7):
  hw/misc/nrf51_rng: Add NRF51 random number generator peripheral
  hw/nvram/nrf51_nvm: Add nRF51 non-volatile memories
  tests: Add bbc:microbit / nRF51 test suite
  hw/gpio/nrf51_gpio: Add nRF51 GPIO peripheral
  tests/microbit-test: Add Tests for nRF51 GPIO
  hw/timer/nrf51_timer: Add nRF51 Timer peripheral
  hw/display/led_matrix: Add LED matrix display device

 Makefile.objs                   |   1 +
 hw/display/Makefile.objs        |   2 +
 hw/display/led_matrix.c         | 262 +++++++++++++++++++++
 hw/gpio/Makefile.objs           |   1 +
 hw/gpio/nrf51_gpio.c            | 305 +++++++++++++++++++++++++
 hw/gpio/trace-events            |   7 +
 hw/misc/Makefile.objs           |   1 +
 hw/misc/nrf51_rng.c             | 273 ++++++++++++++++++++++
 hw/nvram/Makefile.objs          |   1 +
 hw/nvram/nrf51_nvm.c            | 390 ++++++++++++++++++++++++++++++++
 hw/timer/Makefile.objs          |   1 +
 hw/timer/nrf51_timer.c          | 382 +++++++++++++++++++++++++++++++
 hw/timer/trace-events           |   5 +
 include/hw/display/led_matrix.h |  38 ++++
 include/hw/gpio/nrf51_gpio.h    |  57 +++++
 include/hw/misc/nrf51_rng.h     |  71 ++++++
 include/hw/nvram/nrf51_nvm.h    |  56 +++++
 include/hw/timer/nrf51_timer.h  |  63 ++++++
 tests/Makefile.include          |   2 +
 tests/microbit-test.c           | 222 ++++++++++++++++++
 20 files changed, 2140 insertions(+)
 create mode 100644 hw/display/led_matrix.c
 create mode 100644 hw/gpio/nrf51_gpio.c
 create mode 100644 hw/gpio/trace-events
 create mode 100644 hw/misc/nrf51_rng.c
 create mode 100644 hw/nvram/nrf51_nvm.c
 create mode 100644 hw/timer/nrf51_timer.c
 create mode 100644 include/hw/display/led_matrix.h
 create mode 100644 include/hw/gpio/nrf51_gpio.h
 create mode 100644 include/hw/misc/nrf51_rng.h
 create mode 100644 include/hw/nvram/nrf51_nvm.h
 create mode 100644 include/hw/timer/nrf51_timer.h
 create mode 100644 tests/microbit-test.c

-- 
2.18.0


Re: [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support
Posted by Peter Maydell 5 years, 8 months ago
On 6 August 2018 at 11:01, Steffen Görtz <contrib@steffen-goertz.de> wrote:
> This series contains additional peripheral devices for the nRF51822
> microcontroller. Furthermore it includes a device to demultiplex
> the row and column strobes used in embedded devices to drive
> 2D LED dot-matrices.
>
> Included devices:
> - Random Number Generator
> - Non-volatile Memories
> - General purpose I/O
> - Timer
>
> Microbit board-level Devices:
> - LED Matrix
>
> Instantiate of the devices is done in an upcoming patch series.

Thanks for gathering together these patches in one series.
This and the other Cortex-M0-related patchsets are on my queue
to review, but I won't be able to get to them for a little bit
as I'm currently dealing with 3.0 release work. Hopefully by
next week that will have calmed down.

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support
Posted by Peter Maydell 5 years, 8 months ago
On 6 August 2018 at 11:09, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 6 August 2018 at 11:01, Steffen Görtz <contrib@steffen-goertz.de> wrote:
>> This series contains additional peripheral devices for the nRF51822
>> microcontroller. Furthermore it includes a device to demultiplex
>> the row and column strobes used in embedded devices to drive
>> 2D LED dot-matrices.
>>
>> Included devices:
>> - Random Number Generator
>> - Non-volatile Memories
>> - General purpose I/O
>> - Timer
>>
>> Microbit board-level Devices:
>> - LED Matrix
>>
>> Instantiate of the devices is done in an upcoming patch series.
>
> Thanks for gathering together these patches in one series.
> This and the other Cortex-M0-related patchsets are on my queue
> to review, but I won't be able to get to them for a little bit
> as I'm currently dealing with 3.0 release work. Hopefully by
> next week that will have calmed down.

I've now gone through and left some review comments. (Patches
where I haven't replied I thought were covered by Stefan's
review.)

thanks
-- PMM

Re: [Qemu-devel] [PATCH 0/7] arm: nRF51 Devices and Microbit Support
Posted by Steffen Görtz 5 years, 8 months ago
>> Microbit board-level Devices:
>> - LED Matrix
>>
>> Instantiate of the devices is done in an upcoming patch series.
> 
> Thanks for gathering together these patches in one series.
> This and the other Cortex-M0-related patchsets are on my queue
> to review, but I won't be able to get to them for a little bit
> as I'm currently dealing with 3.0 release work. Hopefully by
> next week that will have calmed down.

Great! Thank you!

Steffen