tcg/optimize: Do not skip default processing of dup_vec

[Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec

Richard Henderson posted 1 patch 7 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180805233258.31892-1-richard.henderson@linaro.org

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

tcg/optimize.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec

Posted by Richard Henderson 7 years, 3 months ago

If we do not opimize away dup_vec, we must mark its output as changed.

Fixes: 170ba88f45b
Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/optimize.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index d4ea67e541..5dbe11c3c8 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1094,9 +1094,9 @@ void tcg_optimize(TCGContext *s)
                 tmp = arg_info(op->args[1])->val;
                 tmp = dup_const(TCGOP_VECE(op), tmp);
                 tcg_opt_gen_movi(s, op, op->args[0], tmp);
-                continue;
+                break;
             }
-            break;
+            goto do_default;
 
         CASE_OP_32_64(not):
         CASE_OP_32_64(neg):
-- 
2.17.1

Re: [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec

Posted by Laurent Desnogues 7 years, 3 months ago

Hello,

On Mon, Aug 6, 2018 at 1:32 AM, Richard Henderson
<richard.henderson@linaro.org> wrote:
> If we do not opimize away dup_vec, we must mark its output as changed.
>
> Fixes: 170ba88f45b
> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com>

Thanks,

Laurent

> ---
>  tcg/optimize.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tcg/optimize.c b/tcg/optimize.c
> index d4ea67e541..5dbe11c3c8 100644
> --- a/tcg/optimize.c
> +++ b/tcg/optimize.c
> @@ -1094,9 +1094,9 @@ void tcg_optimize(TCGContext *s)
>                  tmp = arg_info(op->args[1])->val;
>                  tmp = dup_const(TCGOP_VECE(op), tmp);
>                  tcg_opt_gen_movi(s, op, op->args[0], tmp);
> -                continue;
> +                break;
>              }
> -            break;
> +            goto do_default;
>
>          CASE_OP_32_64(not):
>          CASE_OP_32_64(neg):
> --
> 2.17.1
>

Re: [Qemu-devel] [PATCH] tcg/optimize: Do not skip default processing of dup_vec

Posted by Peter Maydell 7 years, 3 months ago

On 6 August 2018 at 06:29, Laurent Desnogues
<laurent.desnogues@gmail.com> wrote:
> Hello,
>
> On Mon, Aug 6, 2018 at 1:32 AM, Richard Henderson
> <richard.henderson@linaro.org> wrote:
>> If we do not opimize away dup_vec, we must mark its output as changed.
>>
>> Fixes: 170ba88f45b
>> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>
> Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com>
>

Applied to master for rc4, thanks.

-- PMM