[v1] pc, virtio: fixes

[Qemu-devel] [PULL 0/5] pc, virtio: fixes

Posted by Michael S. Tsirkin 7 years, 3 months ago

Please consider for 3.0 if there is another rc.

The following changes since commit f7502360397d291be04bc040e9f96c92ff2d8030:

  Update version for v3.0.0-rc3 release (2018-07-31 19:30:17 +0100)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 1c707d6990eaf3db0c9dc4557bba5458977e9f8d:

  tests/acpi: update tables after memory hotplug changes (2018-08-03 11:35:21 +0300)

----------------------------------------------------------------
pc, virtio: fixes

A couple of last minute fixes.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Dou Liyang (2):
      hw/acpi-build: Add a check for memory-less NUMA nodes
      tests/acpi-test: update ACPI tables test blobs

Igor Mammedov (1):
      pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size

Michael S. Tsirkin (1):
      tests/acpi: update tables after memory hotplug changes

Tiwei Bie (1):
      vhost: check region type before casting

 hw/i386/acpi-build.c                  |  28 ++++++++++++++++------------
 hw/virtio/vhost.c                     |   4 +++-
 tests/acpi-test-data/pc/SRAT.dimmpxm  | Bin 472 -> 472 bytes
 tests/acpi-test-data/pc/SRAT.memhp    | Bin 264 -> 264 bytes
 tests/acpi-test-data/pc/SRAT.numamem  | Bin 224 -> 224 bytes
 tests/acpi-test-data/q35/SRAT.dimmpxm | Bin 472 -> 472 bytes
 tests/acpi-test-data/q35/SRAT.memhp   | Bin 264 -> 264 bytes
 tests/acpi-test-data/q35/SRAT.numamem | Bin 224 -> 224 bytes
 8 files changed, 19 insertions(+), 13 deletions(-)

Re: [Qemu-devel] [PULL 0/5] pc, virtio: fixes

Posted by Peter Maydell 7 years, 3 months ago

On 3 August 2018 at 10:27, Michael S. Tsirkin <mst@redhat.com> wrote:
> Please consider for 3.0 if there is another rc.
>
> The following changes since commit f7502360397d291be04bc040e9f96c92ff2d8030:
>
>   Update version for v3.0.0-rc3 release (2018-07-31 19:30:17 +0100)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 1c707d6990eaf3db0c9dc4557bba5458977e9f8d:
>
>   tests/acpi: update tables after memory hotplug changes (2018-08-03 11:35:21 +0300)
>
> ----------------------------------------------------------------
> pc, virtio: fixes
>
> A couple of last minute fixes.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ----------------------------------------------------------------
> Dou Liyang (2):
>       hw/acpi-build: Add a check for memory-less NUMA nodes
>       tests/acpi-test: update ACPI tables test blobs
>
> Igor Mammedov (1):
>       pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size
>
> Michael S. Tsirkin (1):
>       tests/acpi: update tables after memory hotplug changes
>
> Tiwei Bie (1):
>       vhost: check region type before casting

Can you clarify which of these are regressions from 2.12, please?
At this point in the release cycle I only want to apply fixes
for regressions. (Test only updates might also be OK, but I
need more information than just the commit message subject line.)

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/5] pc, virtio: fixes

Posted by Michael S. Tsirkin 7 years, 3 months ago

On Fri, Aug 03, 2018 at 11:45:36AM +0100, Peter Maydell wrote:
> On 3 August 2018 at 10:27, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Please consider for 3.0 if there is another rc.
> >
> > The following changes since commit f7502360397d291be04bc040e9f96c92ff2d8030:
> >
> >   Update version for v3.0.0-rc3 release (2018-07-31 19:30:17 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 1c707d6990eaf3db0c9dc4557bba5458977e9f8d:
> >
> >   tests/acpi: update tables after memory hotplug changes (2018-08-03 11:35:21 +0300)
> >
> > ----------------------------------------------------------------
> > pc, virtio: fixes
> >
> > A couple of last minute fixes.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > ----------------------------------------------------------------
> > Dou Liyang (2):
> >       hw/acpi-build: Add a check for memory-less NUMA nodes
> >       tests/acpi-test: update ACPI tables test blobs

This fixes a regression but from an older release.


> >
> > Igor Mammedov (1):
> >       pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size

This fixes a regression from 2.12.

> > Michael S. Tsirkin (1):
> >       tests/acpi: update tables after memory hotplug changes

This will have to be re-done if we pick this but drop two other fixes.

> >
> > Tiwei Bie (1):
> >       vhost: check region type before casting

Not a regression but an obvious fix.

> 
> Can you clarify which of these are regressions from 2.12, please?
> At this point in the release cycle I only want to apply fixes
> for regressions. (Test only updates might also be OK, but I
> need more information than just the commit message subject line.)
> 
> thanks
> -- PMM

I'll push a variant with just the two patches fixing
regression from 2.12 soon.

-- 
MST

Re: [Qemu-devel] [PULL 0/5] pc, virtio: fixes

Posted by Peter Maydell 7 years, 3 months ago

On 3 August 2018 at 19:14, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Fri, Aug 03, 2018 at 11:45:36AM +0100, Peter Maydell wrote:
>> On 3 August 2018 at 10:27, Michael S. Tsirkin <mst@redhat.com> wrote:
>> > Please consider for 3.0 if there is another rc.
>> >
>> > The following changes since commit f7502360397d291be04bc040e9f96c92ff2d8030:
>> >
>> >   Update version for v3.0.0-rc3 release (2018-07-31 19:30:17 +0100)
>> >
>> > are available in the Git repository at:
>> >
>> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>> >
>> > for you to fetch changes up to 1c707d6990eaf3db0c9dc4557bba5458977e9f8d:
>> >
>> >   tests/acpi: update tables after memory hotplug changes (2018-08-03 11:35:21 +0300)
>> >
>> > ----------------------------------------------------------------
>> > pc, virtio: fixes
>> >
>> > A couple of last minute fixes.
>> >
>> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> >
>> > ----------------------------------------------------------------
>> > Dou Liyang (2):
>> >       hw/acpi-build: Add a check for memory-less NUMA nodes
>> >       tests/acpi-test: update ACPI tables test blobs
>
> This fixes a regression but from an older release.
>
>
>> >
>> > Igor Mammedov (1):
>> >       pc: acpi: fix memory hotplug regression by reducing stub SRAT entry size
>
> This fixes a regression from 2.12.
>
>> > Michael S. Tsirkin (1):
>> >       tests/acpi: update tables after memory hotplug changes
>
> This will have to be re-done if we pick this but drop two other fixes.
>
>> >
>> > Tiwei Bie (1):
>> >       vhost: check region type before casting
>
> Not a regression but an obvious fix.

This is a regression, because it fixes a code change (by me)
that's new in this release.

thanks
-- PMM

Re: [Qemu-devel] [PULL 0/5] pc, virtio: fixes

Posted by Peter Maydell 7 years, 3 months ago

On 3 August 2018 at 10:27, Michael S. Tsirkin <mst@redhat.com> wrote:
> Please consider for 3.0 if there is another rc.
>
> The following changes since commit f7502360397d291be04bc040e9f96c92ff2d8030:
>
>   Update version for v3.0.0-rc3 release (2018-07-31 19:30:17 +0100)
>
> are available in the Git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 1c707d6990eaf3db0c9dc4557bba5458977e9f8d:
>
>   tests/acpi: update tables after memory hotplug changes (2018-08-03 11:35:21 +0300)
>
> ----------------------------------------------------------------
> pc, virtio: fixes
>
> A couple of last minute fixes.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> ----------------------------------------------------------------

Thanks for clarifying the status of the various bugfixes and
preparing the alternate pullreq. After thinking it over, I've
decided to apply this set.

-- PMM

[Qemu-devel] [PULL 3/5] tests/acpi-test: update ACPI tables test blobs

Posted by Michael S. Tsirkin 7 years, 3 months ago

From: Dou Liyang <douly.fnst@cn.fujitsu.com>

Now, QEmu adds a new check for memory-less NUMA nodes in build_srat().

It effects the ACPI test.

So, Update ACPI tables test blobs.

Signed-off-by: Dou Liyang <douly.fnst@cn.fujitsu.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/acpi-test-data/pc/SRAT.numamem  | Bin 224 -> 224 bytes
 tests/acpi-test-data/q35/SRAT.numamem | Bin 224 -> 224 bytes
 2 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/tests/acpi-test-data/pc/SRAT.numamem b/tests/acpi-test-data/pc/SRAT.numamem
index dbc595d9cb85d3fcb5a4243153f42bb431c9de8f..119922f4973f621602047d1dc160519f810922a3 100644
GIT binary patch
delta 24
gcmaFB_<)fsILI;N0RsaA<JXB?78A3|ChpJx0A~{jk^lez

delta 24
gcmaFB_<)fsILI;N0RsaA<ClqC787?#O*Cl%0A_s%T>t<8

diff --git a/tests/acpi-test-data/q35/SRAT.numamem b/tests/acpi-test-data/q35/SRAT.numamem
index dbc595d9cb85d3fcb5a4243153f42bb431c9de8f..119922f4973f621602047d1dc160519f810922a3 100644
GIT binary patch
delta 24
gcmaFB_<)fsILI;N0RsaA<JXB?78A3|ChpJx0A~{jk^lez

delta 24
gcmaFB_<)fsILI;N0RsaA<ClqC787?#O*Cl%0A_s%T>t<8

-- 
MST

[Qemu-devel] [PULL 5/5] tests/acpi: update tables after memory hotplug changes

Posted by Michael S. Tsirkin 7 years, 3 months ago

Previous patch changes acpi tables, update expected
files accordingly.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/acpi-test-data/pc/SRAT.dimmpxm  | Bin 472 -> 472 bytes
 tests/acpi-test-data/pc/SRAT.memhp    | Bin 264 -> 264 bytes
 tests/acpi-test-data/q35/SRAT.dimmpxm | Bin 472 -> 472 bytes
 tests/acpi-test-data/q35/SRAT.memhp   | Bin 264 -> 264 bytes
 4 files changed, 0 insertions(+), 0 deletions(-)

diff --git a/tests/acpi-test-data/pc/SRAT.dimmpxm b/tests/acpi-test-data/pc/SRAT.dimmpxm
index 3b10a607d5bba6cebb97d9174c2a54a577bba9a8..5aa6f693ef9819b3d30cbd76cafb0ee8b5fc5534 100644
GIT binary patch
delta 52
qcmcb?e1n-QILI;N1|tIl<F1Wd>lhXO|Ns9T$YTIu7+{7mfHVMsX$lem

delta 52
scmcb?e1n-QILI;N1|tIl<MxeQ>lhUn7#IYAJP>#Rp%@sLVGJM*038_z5&!@I

diff --git a/tests/acpi-test-data/pc/SRAT.memhp b/tests/acpi-test-data/pc/SRAT.memhp
index e508b4ae3cd9e3000209a4f9597913faa4206ec1..5de8a100a4adf968b79a7b154a7f98123d583474 100644
GIT binary patch
delta 51
pcmeBR>R{pu4ss0PU}RumTso2Kp2GkC|Gxt{3?K{x%rFL!1^_r@2$}!@

delta 51
pcmeBR>R{pu4ss0PU}RumTr`pEo&p09068G=141z{FvA!?8UWLX1)2Z=

diff --git a/tests/acpi-test-data/q35/SRAT.dimmpxm b/tests/acpi-test-data/q35/SRAT.dimmpxm
index 3b10a607d5bba6cebb97d9174c2a54a577bba9a8..5aa6f693ef9819b3d30cbd76cafb0ee8b5fc5534 100644
GIT binary patch
delta 52
qcmcb?e1n-QILI;N1|tIl<F1Wd>lhXO|Ns9T$YTIu7+{7mfHVMsX$lem

delta 52
scmcb?e1n-QILI;N1|tIl<MxeQ>lhUn7#IYAJP>#Rp%@sLVGJM*038_z5&!@I

diff --git a/tests/acpi-test-data/q35/SRAT.memhp b/tests/acpi-test-data/q35/SRAT.memhp
index e508b4ae3cd9e3000209a4f9597913faa4206ec1..5de8a100a4adf968b79a7b154a7f98123d583474 100644
GIT binary patch
delta 51
pcmeBR>R{pu4ss0PU}RumTso2Kp2GkC|Gxt{3?K{x%rFL!1^_r@2$}!@

delta 51
pcmeBR>R{pu4ss0PU}RumTr`pEo&p09068G=141z{FvA!?8UWLX1)2Z=

-- 
MST