hw/ppc: Convert various devices away from old_mmio

[Qemu-devel] [PATCH 0/3] hw/ppc: Convert various devices away from old_mmio

Peter Maydell posted 3 patches 7 years, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180802144430.13870-1-peter.maydell@linaro.org

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

hw/ppc/ppc405_boards.c |  60 +++-----------
hw/ppc/ppc405_uc.c     | 173 ++++++-----------------------------------
hw/ppc/prep.c          |  97 +----------------------
3 files changed, 39 insertions(+), 291 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] hw/ppc: Convert various devices away from old_mmio

Posted by Peter Maydell 7 years, 3 months ago

This patchset removes various uses of old_mmio from minor PPC
devices:
 * hw/ppc/prep had an entirely ifdeffed-out stub of an XCSR device,
   which we remove
 * hw/ppc/ppc_boards had ref405ep_fpga
 * hw/ppc/ppc405_uc had three minor devices

As you can see from the diffstat, the new API provides much
cleaner ways to handle the various different access sizes.

This knocks another five old_mmio uses out of the codebase,
leaving us with just five to go.

NB: Tested only with 'make check'.

thanks
-- PMM

Peter Maydell (3):
  hw/ppc/prep: Remove ifdeffed-out stub of XCSR code
  hw/ppc/ppc_boards: Don't use old_mmio for ref405ep_fpga
  hw/ppc/ppc405_uc: Convert away from old_mmio

 hw/ppc/ppc405_boards.c |  60 +++-----------
 hw/ppc/ppc405_uc.c     | 173 ++++++-----------------------------------
 hw/ppc/prep.c          |  97 +----------------------
 3 files changed, 39 insertions(+), 291 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PATCH 0/3] hw/ppc: Convert various devices away from old_mmio

Posted by David Gibson 7 years, 3 months ago

On Thu, Aug 02, 2018 at 03:44:27PM +0100, Peter Maydell wrote:
> This patchset removes various uses of old_mmio from minor PPC
> devices:
>  * hw/ppc/prep had an entirely ifdeffed-out stub of an XCSR device,
>    which we remove
>  * hw/ppc/ppc_boards had ref405ep_fpga
>  * hw/ppc/ppc405_uc had three minor devices
> 
> As you can see from the diffstat, the new API provides much
> cleaner ways to handle the various different access sizes.
> 
> This knocks another five old_mmio uses out of the codebase,
> leaving us with just five to go.
> 
> NB: Tested only with 'make check'.

Applied to ppc-for-3.1, thanks.

> 
> thanks
> -- PMM
> 
> Peter Maydell (3):
>   hw/ppc/prep: Remove ifdeffed-out stub of XCSR code
>   hw/ppc/ppc_boards: Don't use old_mmio for ref405ep_fpga
>   hw/ppc/ppc405_uc: Convert away from old_mmio
> 
>  hw/ppc/ppc405_boards.c |  60 +++-----------
>  hw/ppc/ppc405_uc.c     | 173 ++++++-----------------------------------
>  hw/ppc/prep.c          |  97 +----------------------
>  3 files changed, 39 insertions(+), 291 deletions(-)
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson