mps2: Implement FPGAIO counters and dual-timer

[Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

Posted by Peter Maydell 7 years, 3 months ago

This patchset adds some missing timer and counter devices
to the MPS2 boards:

 * the MPS2 "fpgaio" register bank includes some registers
   which provide various kinds of free-running counter
 * the boards have an instance fo the CMSDK "dual timer module"

Together these are sufficient for QEMU's mps2-an505
emulation to pass the "timer test" subsection of the
self-test program which can be found (behind a clickthrough
EULA) in the Cortex-M33_IoT_kit_2_0.zip at:
 https://developer.arm.com/products/system-design/development-boards/fpga-prototyping-boards/download-fpga-images

The dual-timer patch ended up a bit big; I can try to split
that up if people would prefer that for review.

thanks
-- PMM

Peter Maydell (5):
  hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters
  hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER
  hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module
  hw/arm/iotkit: Wire up the dualtimer
  hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511

 hw/timer/Makefile.objs                 |   1 +
 include/hw/arm/iotkit.h                |   3 +-
 include/hw/misc/mps2-fpgaio.h          |  10 +
 include/hw/timer/cmsdk-apb-dualtimer.h |  72 ++++
 hw/arm/iotkit.c                        |   8 +-
 hw/arm/mps2.c                          |  11 +
 hw/misc/mps2-fpgaio.c                  | 146 ++++++-
 hw/timer/cmsdk-apb-dualtimer.c         | 515 +++++++++++++++++++++++++
 MAINTAINERS                            |   2 +
 default-configs/arm-softmmu.mak        |   1 +
 hw/timer/trace-events                  |   5 +
 11 files changed, 767 insertions(+), 7 deletions(-)
 create mode 100644 include/hw/timer/cmsdk-apb-dualtimer.h
 create mode 100644 hw/timer/cmsdk-apb-dualtimer.c

-- 
2.17.1

Re: [Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

Posted by no-reply@patchew.org 7 years, 3 months ago

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180730162458.23186-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
72316845d2 hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511
1e40b97496 hw/arm/iotkit: Wire up the dualtimer
b4970bc615 hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module
222de88154 hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER
201fa0eef0 hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters

=== OUTPUT BEGIN ===
Checking PATCH 1/5: hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters...
ERROR: spaces required around that '*' (ctx:VxV)
#131: FILE: hw/misc/mps2-fpgaio.c:193:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 0 warnings, 123 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER...
Checking PATCH 3/5: hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 617 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/5: hw/arm/iotkit: Wire up the dualtimer...
Checking PATCH 5/5: hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

Posted by Peter Maydell 7 years, 2 months ago

Ping? Patch 2 has been reviewed but the rest are still waiting.

thanks
-- PMM

On 30 July 2018 at 17:24, Peter Maydell <peter.maydell@linaro.org> wrote:
> This patchset adds some missing timer and counter devices
> to the MPS2 boards:
>
>  * the MPS2 "fpgaio" register bank includes some registers
>    which provide various kinds of free-running counter
>  * the boards have an instance fo the CMSDK "dual timer module"
>
> Together these are sufficient for QEMU's mps2-an505
> emulation to pass the "timer test" subsection of the
> self-test program which can be found (behind a clickthrough
> EULA) in the Cortex-M33_IoT_kit_2_0.zip at:
>  https://developer.arm.com/products/system-design/development-boards/fpga-prototyping-boards/download-fpga-images
>
> The dual-timer patch ended up a bit big; I can try to split
> that up if people would prefer that for review.
>
> thanks
> -- PMM
>
> Peter Maydell (5):
>   hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters
>   hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER
>   hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module
>   hw/arm/iotkit: Wire up the dualtimer
>   hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511
>
>  hw/timer/Makefile.objs                 |   1 +
>  include/hw/arm/iotkit.h                |   3 +-
>  include/hw/misc/mps2-fpgaio.h          |  10 +
>  include/hw/timer/cmsdk-apb-dualtimer.h |  72 ++++
>  hw/arm/iotkit.c                        |   8 +-
>  hw/arm/mps2.c                          |  11 +
>  hw/misc/mps2-fpgaio.c                  | 146 ++++++-
>  hw/timer/cmsdk-apb-dualtimer.c         | 515 +++++++++++++++++++++++++
>  MAINTAINERS                            |   2 +
>  default-configs/arm-softmmu.mak        |   1 +
>  hw/timer/trace-events                  |   5 +
>  11 files changed, 767 insertions(+), 7 deletions(-)
>  create mode 100644 include/hw/timer/cmsdk-apb-dualtimer.h
>  create mode 100644 hw/timer/cmsdk-apb-dualtimer.c

Re: [Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

Posted by no-reply@patchew.org 7 years, 3 months ago

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20180730162458.23186-1-peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 0/5] mps2: Implement FPGAIO counters and dual-timer

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ddb70544a8 hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511
bdb50460f4 hw/arm/iotkit: Wire up the dualtimer
008a768e12 hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module
5a008a3545 hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER
752c65591e hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters

=== OUTPUT BEGIN ===
Checking PATCH 1/5: hw/misc/mps2-fpgaio: Implement 1Hz and 100Hz counters...
ERROR: spaces required around that '*' (ctx:VxV)
#131: FILE: hw/misc/mps2-fpgaio.c:193:
+    .subsections = (const VMStateDescription*[]) {
                                             ^

total: 1 errors, 0 warnings, 123 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/5: hw/misc/mps2-fpgaio: Implement PSCNTR and COUNTER...
Checking PATCH 3/5: hw/timer/cmsdk-apb-dualtimer: Implement CMSDK dual timer module...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 617 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/5: hw/arm/iotkit: Wire up the dualtimer...
Checking PATCH 5/5: hw/arm/mps2: Wire up dual-timer in mps2-an385 and mps2-an511...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com