1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] cryptodev: remove dead code

Paolo Bonzini posted 1 patch 7 years, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180730085121.12523-1-pbonzini@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Test docker-quick@centos7 passed
backends/cryptodev-vhost-user.c | 5 -----
1 file changed, 5 deletions(-)
[Qemu-devel] [PATCH] cryptodev: remove dead code
Posted by Paolo Bonzini 7 years, 3 months ago 
Reported by Coverity as CID 1390600.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 backends/cryptodev-vhost-user.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
index d52daccfcd..d539f14d59 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
 {
     CryptoDevBackendVhostUser *s = opaque;
     CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
-    Error *err = NULL;
     int queues = b->conf.peers.queues;
 
     assert(queues < MAX_CRYPTO_QUEUE_NUM);
@@ -174,10 +173,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
         cryptodev_vhost_user_stop(queues, s);
         break;
     }
-
-    if (err) {
-        error_report_err(err);
-    }
 }
 
 static void cryptodev_vhost_user_init(
-- 
2.17.1
Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
Posted by Gonglei (Arei) 7 years, 3 months ago 
> -----Original Message-----
> From: Qemu-devel
> [mailto:qemu-devel-bounces+arei.gonglei=huawei.com@nongnu.org] On
> Behalf Of Paolo Bonzini
> Sent: Monday, July 30, 2018 4:51 PM
> To: qemu-devel@nongnu.org
> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
> 
> Reported by Coverity as CID 1390600.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  backends/cryptodev-vhost-user.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
> index d52daccfcd..d539f14d59 100644
> --- a/backends/cryptodev-vhost-user.c
> +++ b/backends/cryptodev-vhost-user.c
> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque,
> int event)
>  {
>      CryptoDevBackendVhostUser *s = opaque;
>      CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
> -    Error *err = NULL;
>      int queues = b->conf.peers.queues;
> 
>      assert(queues < MAX_CRYPTO_QUEUE_NUM);
> @@ -174,10 +173,6 @@ static void cryptodev_vhost_user_event(void
> *opaque, int event)
>          cryptodev_vhost_user_stop(queues, s);
>          break;
>      }
> -
> -    if (err) {
> -        error_report_err(err);
> -    }
>  }
> 
>  static void cryptodev_vhost_user_init(
> --
> 2.17.1
> 

Reviewed-by: Gonglei <arei.gonglei@huawei.com>

Thanks,
-Gonglei
Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
Posted by Peter Maydell 7 years, 3 months ago 
On 30 July 2018 at 09:51, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Reported by Coverity as CID 1390600.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---

This already has a reviewed patch on-list for this from
back in April:

https://patchwork.ozlabs.org/patch/906041/

so I think we should just apply that.

thanks
-- PMM
Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
Posted by Gonglei (Arei) 7 years, 3 months ago 

> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Monday, July 30, 2018 6:49 PM
> To: Paolo Bonzini <pbonzini@redhat.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; Gonglei (Arei)
> <arei.gonglei@huawei.com>
> Subject: Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
> 
> On 30 July 2018 at 09:51, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Reported by Coverity as CID 1390600.
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> 
> This already has a reviewed patch on-list for this from
> back in April:
> 
> https://patchwork.ozlabs.org/patch/906041/
> 
> so I think we should just apply that.
> 
Oh, yes. Would you pick it up directly? Or by qemu-trivial?

Thanks,
-Gonglei
Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
Posted by Zhoujian (jay) 7 years, 3 months ago 
Hi Paolo,

I've posted a patch before, pls see
https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05215.html

which reviewed by Stefan
https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg01549.html

It seems that it hasn't been merged. Could you pick it up pls?

Regards,
Jay

> -----Original Message-----
> From: Qemu-devel [mailto:qemu-devel-
> bounces+jianjay.zhou=huawei.com@nongnu.org] On Behalf Of Paolo Bonzini
> Sent: Monday, July 30, 2018 4:51 PM
> To: qemu-devel@nongnu.org
> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
> 
> Reported by Coverity as CID 1390600.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  backends/cryptodev-vhost-user.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-
> user.c index d52daccfcd..d539f14d59 100644
> --- a/backends/cryptodev-vhost-user.c
> +++ b/backends/cryptodev-vhost-user.c
> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int
> event)  {
>      CryptoDevBackendVhostUser *s = opaque;
>      CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
> -    Error *err = NULL;
>      int queues = b->conf.peers.queues;
> 
>      assert(queues < MAX_CRYPTO_QUEUE_NUM); @@ -174,10 +173,6 @@ static void
> cryptodev_vhost_user_event(void *opaque, int event)
>          cryptodev_vhost_user_stop(queues, s);
>          break;
>      }
> -
> -    if (err) {
> -        error_report_err(err);
> -    }
>  }
> 
>  static void cryptodev_vhost_user_init(
> --
> 2.17.1
>
Re: [Qemu-devel] [PATCH] cryptodev: remove dead code
Posted by Paolo Bonzini 7 years, 3 months ago 
On 30/07/2018 13:50, Zhoujian (jay) wrote:
> Hi Paolo,
> 
> I've posted a patch before, pls see
> https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05215.html
> 
> which reviewed by Stefan
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg01549.html
> 
> It seems that it hasn't been merged. Could you pick it up pls?

Yes, I will.

Paolo

> Regards,
> Jay
> 
>> -----Original Message-----
>> From: Qemu-devel [mailto:qemu-devel-
>> bounces+jianjay.zhou=huawei.com@nongnu.org] On Behalf Of Paolo Bonzini
>> Sent: Monday, July 30, 2018 4:51 PM
>> To: qemu-devel@nongnu.org
>> Subject: [Qemu-devel] [PATCH] cryptodev: remove dead code
>>
>> Reported by Coverity as CID 1390600.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  backends/cryptodev-vhost-user.c | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-
>> user.c index d52daccfcd..d539f14d59 100644
>> --- a/backends/cryptodev-vhost-user.c
>> +++ b/backends/cryptodev-vhost-user.c
>> @@ -157,7 +157,6 @@ static void cryptodev_vhost_user_event(void *opaque, int
>> event)  {
>>      CryptoDevBackendVhostUser *s = opaque;
>>      CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
>> -    Error *err = NULL;
>>      int queues = b->conf.peers.queues;
>>
>>      assert(queues < MAX_CRYPTO_QUEUE_NUM); @@ -174,10 +173,6 @@ static void
>> cryptodev_vhost_user_event(void *opaque, int event)
>>          cryptodev_vhost_user_stop(queues, s);
>>          break;
>>      }
>> -
>> -    if (err) {
>> -        error_report_err(err);
>> -    }
>>  }
>>
>>  static void cryptodev_vhost_user_init(
>> --
>> 2.17.1
>>
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.