[v2] QObject patches for 2018-07-27 (3.0.0-rc3)

[Qemu-devel] [PULL v2 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)

Markus Armbruster posted 3 patches 7 years, 3 months ago

Diff against v1
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180728071638.17077-1-armbru@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

block/blkdebug.c           |  2 +-
block/blkverify.c          |  2 +-
block/nbd.c                |  2 +-
include/qapi/qmp/qstring.h |  2 +-
qobject/qstring.c          | 12 ++++++++----
tests/check-qobject.c      |  2 +-
tests/check-qstring.c      |  2 +-
7 files changed, 14 insertions(+), 10 deletions(-)

Expand all Fold all

[Qemu-devel] [PULL v2 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)

Posted by Markus Armbruster 7 years, 3 months ago

The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc:

  Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100)

are available in the Git repository at:

  git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27-v2

for you to fetch changes up to ba891d68b4ff17faaea3d3a8bfd82af3eed0a134:

  qstring: Move qstring_from_substr()'s @end one to the right (2018-07-28 09:09:58 +0200)

----------------------------------------------------------------
QObject patches for 2018-07-27 (3.0.0-rc3)

This pull request fixes an integer overflow bug, and hardens the code
in question a bit.  Abuse of QMP can make the bug crash QEMU, so it
seems worth fixing at this late stage.

----------------------------------------------------------------
Markus Armbruster (2):
      qstring: Assert size calculations don't overflow
      qstring: Move qstring_from_substr()'s @end one to the right

liujunjie (1):
      qstring: Fix qstring_from_substr() not to provoke int overflow

 block/blkdebug.c           |  2 +-
 block/blkverify.c          |  2 +-
 block/nbd.c                |  2 +-
 include/qapi/qmp/qstring.h |  2 +-
 qobject/qstring.c          | 12 ++++++++----
 tests/check-qobject.c      |  2 +-
 tests/check-qstring.c      |  2 +-
 7 files changed, 14 insertions(+), 10 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PULL v2 0/3] QObject patches for 2018-07-27 (3.0.0-rc3)

Posted by Peter Maydell 7 years, 3 months ago

On 28 July 2018 at 08:16, Markus Armbruster <armbru@redhat.com> wrote:
> The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc:
>
>   Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27-v2
>
> for you to fetch changes up to ba891d68b4ff17faaea3d3a8bfd82af3eed0a134:
>
>   qstring: Move qstring_from_substr()'s @end one to the right (2018-07-28 09:09:58 +0200)
>
> ----------------------------------------------------------------
> QObject patches for 2018-07-27 (3.0.0-rc3)
>
> This pull request fixes an integer overflow bug, and hardens the code
> in question a bit.  Abuse of QMP can make the bug crash QEMU, so it
> seems worth fixing at this late stage.
>
> ----------------------------------------------------------------
> Markus Armbruster (2):
>       qstring: Assert size calculations don't overflow
>       qstring: Move qstring_from_substr()'s @end one to the right
>
> liujunjie (1):
>       qstring: Fix qstring_from_substr() not to provoke int overflow
>

Applied, thanks.

-- PMM