arm/smmuv3: Fix missing VMSD terminator

[Qemu-devel] [PATCH] arm/smmuv3: Fix missing VMSD terminator

Dr. David Alan Gilbert (git) posted 1 patch 7 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180727135406.15132-1-dgilbert@redhat.com

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

hw/arm/smmuv3.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] arm/smmuv3: Fix missing VMSD terminator

Posted by Dr. David Alan Gilbert (git) 7 years, 3 months ago

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

The 'vmstate_smmuv3_queue' is missing the end-of-list marker.

Fixes: 10a83cb9887
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
 hw/arm/smmuv3.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
index 39fbcbf577..40a86c1895 100644
--- a/hw/arm/smmuv3.c
+++ b/hw/arm/smmuv3.c
@@ -1414,6 +1414,8 @@ static const VMStateDescription vmstate_smmuv3_queue = {
         VMSTATE_UINT32(prod, SMMUQueue),
         VMSTATE_UINT32(cons, SMMUQueue),
         VMSTATE_UINT8(log2size, SMMUQueue),
+
+        VMSTATE_END_OF_LIST(),
     },
 };
 
-- 
2.17.1

Re: [Qemu-devel] [PATCH] arm/smmuv3: Fix missing VMSD terminator

Posted by Peter Maydell 7 years, 3 months ago

On 27 July 2018 at 14:54, Dr. David Alan Gilbert (git)
<dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> The 'vmstate_smmuv3_queue' is missing the end-of-list marker.
>
> Fixes: 10a83cb9887
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
>  hw/arm/smmuv3.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/smmuv3.c b/hw/arm/smmuv3.c
> index 39fbcbf577..40a86c1895 100644
> --- a/hw/arm/smmuv3.c
> +++ b/hw/arm/smmuv3.c
> @@ -1414,6 +1414,8 @@ static const VMStateDescription vmstate_smmuv3_queue = {
>          VMSTATE_UINT32(prod, SMMUQueue),
>          VMSTATE_UINT32(cons, SMMUQueue),
>          VMSTATE_UINT8(log2size, SMMUQueue),
> +
> +        VMSTATE_END_OF_LIST(),
>      },
>  };

Thanks, applied to target-arm.next for 3.0. (I dropped the extra
blank line.)

-- PMM