[v1] qstring: Safer qstring_from_substr()

[Qemu-devel] [PATCH 0/2] qstring: Safer qstring_from_substr()

Markus Armbruster posted 2 patches 7 years, 3 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180726061844.25992-1-armbru@redhat.com

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

There is a newer version of this series

block/blkdebug.c      |  2 +-
block/blkverify.c     |  2 +-
block/nbd.c           |  2 +-
qobject/qstring.c     | 10 +++++++---
tests/check-qobject.c |  2 +-
tests/check-qstring.c |  2 +-
6 files changed, 12 insertions(+), 8 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] qstring: Safer qstring_from_substr()

Posted by Markus Armbruster 7 years, 3 months ago

This is based on liujunjie's "[PATCH] qstring: Fix
qstring_from_substr() not to provoke int overflow".  I intend to get
that one into 3.0 as a bug fix.  I figure PATCH 1 should go into 3.0
as a safety measure.  I'm not sure about PATCH 2.  Please review.

Based-on: 20180724134339.17832-1-liujunjie23@huawei.com

Markus Armbruster (2):
  qstring: Assert size calculations don't overflow
  qstring: Move qstring_from_substr()'s @end one to the right

 block/blkdebug.c      |  2 +-
 block/blkverify.c     |  2 +-
 block/nbd.c           |  2 +-
 qobject/qstring.c     | 10 +++++++---
 tests/check-qobject.c |  2 +-
 tests/check-qstring.c |  2 +-
 6 files changed, 12 insertions(+), 8 deletions(-)

-- 
2.17.1