tcg/i386: Mark xmm registers call-clobbered

[Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered

Richard Henderson posted 1 patch 7 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180723012941.16920-1-richard.henderson@linaro.org

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

tcg/i386/tcg-target.inc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered

Posted by Richard Henderson 7 years, 3 months ago

When host vector registers and operations were introduced, I failed
to mark the registers call clobbered as required by the ABI.

Fixes: 770c2fc7bb7
Cc: qemu-stable@nongnu.org
Reported-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 tcg/i386/tcg-target.inc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tcg/i386/tcg-target.inc.c b/tcg/i386/tcg-target.inc.c
index e87b0d445e..a91e4f1313 100644
--- a/tcg/i386/tcg-target.inc.c
+++ b/tcg/i386/tcg-target.inc.c
@@ -3532,7 +3532,7 @@ static void tcg_target_init(TCGContext *s)
         tcg_target_available_regs[TCG_TYPE_V256] = ALL_VECTOR_REGS;
     }
 
-    tcg_target_call_clobber_regs = 0;
+    tcg_target_call_clobber_regs = ALL_VECTOR_REGS;
     tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_EAX);
     tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_EDX);
     tcg_regset_set_reg(tcg_target_call_clobber_regs, TCG_REG_ECX);
-- 
2.17.1

Re: [Qemu-devel] [PATCH for-3.0] tcg/i386: Mark xmm registers call-clobbered

Posted by Jason A. Donenfeld 7 years, 3 months ago

Hi Richard,

I can confirm this fixes the issue.
https://www.wireguard.com/build-status/ is now all green again.

Thanks,
Jason