spice-display locking fixes (cursors)?

[Qemu-devel] [RFC/RFT PATCH 0/2] spice-display locking fixes (cursors)?

Posted by Paolo Bonzini 5 years, 9 months ago

The first issue was found by Coverity and should be trivial.  The second
however made me wonder how to test the code and whether it has ever
worked, because in theory it should be an instant deadlock whenever
qemu_spice_cursor_refresh_bh is called.

So I'm looking for help.  In fact, the changes are not tested beyond
compilation.

Paolo

Paolo Bonzini (2):
  spice-display: access ptr_x/ptr_y under Mutex
  spice-display: fix qemu_spice_cursor_refresh_bh locking

 ui/spice-display.c | 37 +++++++++++++++++++++++++------------
 1 file changed, 25 insertions(+), 12 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [RFC/RFT PATCH 0/2] spice-display locking fixes (cursors)?

Posted by Paolo Bonzini 5 years, 8 months ago

On 20/07/2018 08:31, Paolo Bonzini wrote:
> The first issue was found by Coverity and should be trivial.  The second
> however made me wonder how to test the code and whether it has ever
> worked, because in theory it should be an instant deadlock whenever
> qemu_spice_cursor_refresh_bh is called.
> 
> So I'm looking for help.  In fact, the changes are not tested beyond
> compilation.
> 
> Paolo
> 
> Paolo Bonzini (2):
>   spice-display: access ptr_x/ptr_y under Mutex
>   spice-display: fix qemu_spice_cursor_refresh_bh locking
> 
>  ui/spice-display.c | 37 +++++++++++++++++++++++++------------
>  1 file changed, 25 insertions(+), 12 deletions(-)
> 

Ping?

Paolo

Re: [Qemu-devel] [RFC/RFT PATCH 0/2] spice-display locking fixes (cursors)?

Posted by Marc-André Lureau 5 years, 8 months ago

On Mon, Aug 20, 2018 at 5:29 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 20/07/2018 08:31, Paolo Bonzini wrote:
> > The first issue was found by Coverity and should be trivial.  The second
> > however made me wonder how to test the code and whether it has ever
> > worked, because in theory it should be an instant deadlock whenever
> > qemu_spice_cursor_refresh_bh is called.
> >
> > So I'm looking for help.  In fact, the changes are not tested beyond
> > compilation.
> >
> > Paolo
> >
> > Paolo Bonzini (2):
> >   spice-display: access ptr_x/ptr_y under Mutex
> >   spice-display: fix qemu_spice_cursor_refresh_bh locking
> >
> >  ui/spice-display.c | 37 +++++++++++++++++++++++++------------
> >  1 file changed, 25 insertions(+), 12 deletions(-)
> >
>
> Ping?
>


tested &
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>



-- 
Marc-André Lureau

Re: [Qemu-devel] [RFC/RFT PATCH 0/2] spice-display locking fixes (cursors)?

Posted by Gerd Hoffmann 5 years, 8 months ago

On Fri, Jul 20, 2018 at 08:31:07AM +0200, Paolo Bonzini wrote:
> The first issue was found by Coverity and should be trivial.  The second
> however made me wonder how to test the code and whether it has ever
> worked, because in theory it should be an instant deadlock whenever
> qemu_spice_cursor_refresh_bh is called.

Added to ui queue.

thanks,
  Gerd