Multiple fixes and improvements to TLS tests

[Qemu-devel] [PATCH for 3.0 0/4] Multiple fixes and improvements to TLS tests

Daniel P. Berrangé posted 4 patches 5 years, 9 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180718093815.8104-1-berrange@redhat.com

Test docker-mingw@fedora passed

Test checkpatch passed

Test docker-quick@centos7 passed

stubs/error-printf.c             |  5 +-
tests/crypto-tls-x509-helpers.c  |  4 +-
tests/test-crypto-tlscredsx509.c | 11 +----
tests/test-crypto-tlssession.c   | 80 ++++++++++++--------------------
tests/test-io-channel-tls.c      | 24 ++++------
tests/test-vmstate.c             |  3 ++
6 files changed, 51 insertions(+), 76 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH for 3.0 0/4] Multiple fixes and improvements to TLS tests

Posted by Daniel P. Berrangé 5 years, 9 months ago

The switch to enable TLS 1.3 protocol support in GNUTLS in Fedora
exposed a subtle flaw in our TLS unit tests. This was horrible to debug
because of bad error reporting in our tests which caused all the error
messages to be irretrievably lost instead of displayed on stderr.

Daniel P. Berrangé (4):
  tests: call qcrypto_init instead of gnutls_global_init
  tests: don't silence error reporting for all tests
  tests: use error_abort in places expecting errors
  tests: fix TLS handshake failure with TLS 1.3

 stubs/error-printf.c             |  5 +-
 tests/crypto-tls-x509-helpers.c  |  4 +-
 tests/test-crypto-tlscredsx509.c | 11 +----
 tests/test-crypto-tlssession.c   | 80 ++++++++++++--------------------
 tests/test-io-channel-tls.c      | 24 ++++------
 tests/test-vmstate.c             |  3 ++
 6 files changed, 51 insertions(+), 76 deletions(-)

-- 
2.17.1