[Qemu-devel] [PATCH 06/25] check: Only test eepro100 when it is compiled in

Juan Quintela posted 25 patches 7 years, 3 months ago
[Qemu-devel] [PATCH 06/25] check: Only test eepro100 when it is compiled in
Posted by Juan Quintela 7 years, 3 months ago
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/Makefile.include | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index ae77d26932..560f486416 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -218,8 +218,8 @@ gcov-files-pci-y += hw/net/rtl8139.c
 check-qtest-pci-y += tests/pcnet-test$(EXESUF)
 gcov-files-pci-y += hw/net/pcnet.c
 gcov-files-pci-y += hw/net/pcnet-pci.c
-check-qtest-pci-y += tests/eepro100-test$(EXESUF)
-gcov-files-pci-y += hw/net/eepro100.c
+check-qtest-pci-$(CONFIG_EEPRO100_PCI) += tests/eepro100-test$(EXESUF)
+gcov-files-pci-$(CONFIG_EEPRO100_PCI) += hw/net/eepro100.c
 check-qtest-pci-$(CONFIG_NE2000_PCI) += tests/ne2000-test$(EXESUF)
 gcov-files-pci-$(CONFIG_NE2000_PCI) += hw/net/ne2000.c
 check-qtest-pci-y += tests/nvme-test$(EXESUF)
-- 
2.17.1


Re: [Qemu-devel] [PATCH 06/25] check: Only test eepro100 when it is compiled in
Posted by Thomas Huth 7 years, 3 months ago
On 17.07.2018 13:33, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  tests/Makefile.include | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index ae77d26932..560f486416 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -218,8 +218,8 @@ gcov-files-pci-y += hw/net/rtl8139.c
>  check-qtest-pci-y += tests/pcnet-test$(EXESUF)
>  gcov-files-pci-y += hw/net/pcnet.c
>  gcov-files-pci-y += hw/net/pcnet-pci.c
> -check-qtest-pci-y += tests/eepro100-test$(EXESUF)
> -gcov-files-pci-y += hw/net/eepro100.c
> +check-qtest-pci-$(CONFIG_EEPRO100_PCI) += tests/eepro100-test$(EXESUF)
> +gcov-files-pci-$(CONFIG_EEPRO100_PCI) += hw/net/eepro100.c
>  check-qtest-pci-$(CONFIG_NE2000_PCI) += tests/ne2000-test$(EXESUF)
>  gcov-files-pci-$(CONFIG_NE2000_PCI) += hw/net/ne2000.c
>  check-qtest-pci-y += tests/nvme-test$(EXESUF)

Reviewed-by: Thomas Huth <thuth@redhat.com>