[libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list

Markus Armbruster posted 2 patches 7 years, 3 months ago
[libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Markus Armbruster 7 years, 3 months ago
Libvirt developers would like to be copied on patches to qemu-doc
appendix "Deprecated features".  Do them the favor.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 20eef3cb61..666e936812 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2194,6 +2194,10 @@ M: Daniel P. Berrange <berrange@redhat.com>
 S: Odd Fixes
 F: docs/devel/build-system.txt
 
+Incompatible changes
+R: libvir-list@redhat.com
+F: qemu-deprecated.texi
+
 Build System
 ------------
 GIT submodules
-- 
2.17.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Thomas Huth 7 years, 3 months ago
On 16.07.2018 09:32, Markus Armbruster wrote:
> Libvirt developers would like to be copied on patches to qemu-doc
> appendix "Deprecated features".  Do them the favor.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 20eef3cb61..666e936812 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2194,6 +2194,10 @@ M: Daniel P. Berrange <berrange@redhat.com>
>  S: Odd Fixes
>  F: docs/devel/build-system.txt
>  
> +Incompatible changes
> +R: libvir-list@redhat.com
> +F: qemu-deprecated.texi

Should we have a maintainer for the file, too? (I guess not, because
deprecation patches should go through the specific subsystems...)
And what about a "S:" line?

Anyway:

Reviewed-by: Thomas Huth <thuth@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Cornelia Huck 7 years, 3 months ago
On Mon, 16 Jul 2018 09:54:12 +0200
Thomas Huth <thuth@redhat.com> wrote:

> On 16.07.2018 09:32, Markus Armbruster wrote:
> > Libvirt developers would like to be copied on patches to qemu-doc
> > appendix "Deprecated features".  Do them the favor.
> > 
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> >  MAINTAINERS | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 20eef3cb61..666e936812 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2194,6 +2194,10 @@ M: Daniel P. Berrange <berrange@redhat.com>
> >  S: Odd Fixes
> >  F: docs/devel/build-system.txt
> >  
> > +Incompatible changes
> > +R: libvir-list@redhat.com
> > +F: qemu-deprecated.texi  
> 
> Should we have a maintainer for the file, too? (I guess not, because
> deprecation patches should go through the specific subsystems...)

I don't think adding a maintainer makes sense for this file.

> And what about a "S:" line?

I don't think that makes too much sense, either.

If anything, qemu-deprecated.texi should be in a category 'maintained
by everybody', i.e. qemu-devel. Just like qemu-doc.texi, which does not
have an entry in MAINTAINERS at all.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [Qemu-devel] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Markus Armbruster 7 years, 3 months ago
Cornelia Huck <cohuck@redhat.com> writes:

> On Mon, 16 Jul 2018 09:54:12 +0200
> Thomas Huth <thuth@redhat.com> wrote:
>
>> On 16.07.2018 09:32, Markus Armbruster wrote:
>> > Libvirt developers would like to be copied on patches to qemu-doc
>> > appendix "Deprecated features".  Do them the favor.
>> > 
>> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> > ---
>> >  MAINTAINERS | 4 ++++
>> >  1 file changed, 4 insertions(+)
>> > 
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 20eef3cb61..666e936812 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -2194,6 +2194,10 @@ M: Daniel P. Berrange <berrange@redhat.com>
>> >  S: Odd Fixes
>> >  F: docs/devel/build-system.txt
>> >  
>> > +Incompatible changes
>> > +R: libvir-list@redhat.com
>> > +F: qemu-deprecated.texi  
>> 
>> Should we have a maintainer for the file, too? (I guess not, because
>> deprecation patches should go through the specific subsystems...)
>
> I don't think adding a maintainer makes sense for this file.

This MAINTAINERS entry doesn't declare maintainers, only reviewers.

We can change that if a maintainer steps up.

>> And what about a "S:" line?
>
> I don't think that makes too much sense, either.
>
> If anything, qemu-deprecated.texi should be in a category 'maintained
> by everybody', i.e. qemu-devel. Just like qemu-doc.texi, which does not
> have an entry in MAINTAINERS at all.

Just like all the other files that lack a maintainer.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Cornelia Huck 7 years, 3 months ago
On Mon, 16 Jul 2018 09:32:26 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Libvirt developers would like to be copied on patches to qemu-doc
> appendix "Deprecated features".  Do them the favor.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Daniel P. Berrangé 7 years, 3 months ago
On Mon, Jul 16, 2018 at 09:32:26AM +0200, Markus Armbruster wrote:
> Libvirt developers would like to be copied on patches to qemu-doc
> appendix "Deprecated features".  Do them the favor.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 20eef3cb61..666e936812 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2194,6 +2194,10 @@ M: Daniel P. Berrange <berrange@redhat.com>
>  S: Odd Fixes
>  F: docs/devel/build-system.txt
>  
> +Incompatible changes
> +R: libvir-list@redhat.com
> +F: qemu-deprecated.texi
> +
>  Build System
>  ------------
>  GIT submodules

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Note, that libvir-list requires senders to be subscribed before mails are
delivered, otherwise they go into moderation queue. My normal approach. as
the person moderating, is to whitelist all human senders who get moderated,
so it is only a one-time pain point per person.

Thankyou spammers :-(

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 2/2] MAINTAINERS: New section "Incompatible changes", copy libvir-list
Posted by Eric Blake 7 years, 3 months ago
On 07/16/2018 04:39 AM, Daniel P. Berrangé wrote:

> 
> Note, that libvir-list requires senders to be subscribed before mails are
> delivered, otherwise they go into moderation queue. My normal approach. as
> the person moderating, is to whitelist all human senders who get moderated,
> so it is only a one-time pain point per person.

Actually, the list bot is even more stupid than that - a first-time 
poster that subscribes first is STILL moderated (and sometimes you can 
see evidence of that when someone posts 2 or 3 nearly identical messages 
in a short time - first before subscribing, then again after, thinking 
that subscribing will make a difference). Whitelisting happens 
independently from subscription.

> 
> Thankyou spammers :-(

But also a hearty thank you to all list moderators that reduce the 
amount of spam actually making it to the list.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list