iotests: Disallow compat=0.10 in 223

[Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223

Max Reitz posted 1 patch 7 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180713191506.14484-1-mreitz@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

tests/qemu-iotests/223 | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223

Posted by Max Reitz 7 years, 3 months ago

223 tests persistent dirty bitmaps which are not supported in
compat=0.10, so that option is unsupported for this test.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 tests/qemu-iotests/223 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223
index b63b7a4f9e..8b1859c2dd 100755
--- a/tests/qemu-iotests/223
+++ b/tests/qemu-iotests/223
@@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
 _supported_fmt qcow2
 _supported_proto file # uses NBD as well
 _supported_os Linux
+# Persistent dirty bitmaps require compat=1.1
+_unsupported_imgopts 'compat=0.10'
 
 function do_run_qemu()
 {
-- 
2.17.1

Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223

Posted by John Snow 7 years, 3 months ago


On 07/13/2018 03:15 PM, Max Reitz wrote:
> 223 tests persistent dirty bitmaps which are not supported in
> compat=0.10, so that option is unsupported for this test.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  tests/qemu-iotests/223 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/223 b/tests/qemu-iotests/223
> index b63b7a4f9e..8b1859c2dd 100755
> --- a/tests/qemu-iotests/223
> +++ b/tests/qemu-iotests/223
> @@ -40,6 +40,8 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  _supported_fmt qcow2
>  _supported_proto file # uses NBD as well
>  _supported_os Linux
> +# Persistent dirty bitmaps require compat=1.1
> +_unsupported_imgopts 'compat=0.10'
>  
>  function do_run_qemu()
>  {
> 

Thanks for catching this :)

Tested-by: John Snow <jsnow@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>

Re: [Qemu-devel] [PATCH] iotests: Disallow compat=0.10 in 223

Posted by Kevin Wolf 7 years, 3 months ago

Am 13.07.2018 um 21:15 hat Max Reitz geschrieben:
> 223 tests persistent dirty bitmaps which are not supported in
> compat=0.10, so that option is unsupported for this test.
> 
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Thanks, applied to the block branch.

Kevin