[Qemu-devel] [PATCH] iotests: 222: Don't run with luks

Fam Zheng posted 1 patch 11 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180710093802.28308-1-famz@redhat.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
tests/qemu-iotests/222 | 2 ++
1 file changed, 2 insertions(+)

[Qemu-devel] [PATCH] iotests: 222: Don't run with luks

Posted by Fam Zheng 11 weeks ago
Luks needs special parameters to operate the image. Since this test is
focusing on image fleecing, skip skip that format.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/222 | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
index ff3bfc1470..0ead56d574 100644
--- a/tests/qemu-iotests/222
+++ b/tests/qemu-iotests/222
@@ -25,6 +25,8 @@ import iotests
 from iotests import log, qemu_img, qemu_io, qemu_io_silent
 
 iotests.verify_platform(['linux'])
+iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk',
+                                            'vhdx', 'raw'])
 
 patterns = [("0x5d", "0",         "64k"),
             ("0xd5", "1M",        "64k"),
-- 
2.17.1


Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks

Posted by Kevin Wolf 11 weeks ago
Am 10.07.2018 um 11:38 hat Fam Zheng geschrieben:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>

Thanks, applied to the block branch.

Kevin

Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks

Posted by John Snow 11 weeks ago

On 07/10/2018 05:38 AM, Fam Zheng wrote:
> Luks needs special parameters to operate the image. Since this test is
> focusing on image fleecing, skip skip that format.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/222 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> index ff3bfc1470..0ead56d574 100644
> --- a/tests/qemu-iotests/222
> +++ b/tests/qemu-iotests/222
> @@ -25,6 +25,8 @@ import iotests
>  from iotests import log, qemu_img, qemu_io, qemu_io_silent
>  
>  iotests.verify_platform(['linux'])
> +iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk',
> +                                            'vhdx', 'raw'])
>  
>  patterns = [("0x5d", "0",         "64k"),
>              ("0xd5", "1M",        "64k"),
> 

Ah; do we not have a nicer way to exclude just one format? Evidently not.

Apologies for breaking LUKS.

--js

Re: [Qemu-devel] [PATCH] iotests: 222: Don't run with luks

Posted by Kevin Wolf 11 weeks ago
Am 10.07.2018 um 17:34 hat John Snow geschrieben:
> 
> 
> On 07/10/2018 05:38 AM, Fam Zheng wrote:
> > Luks needs special parameters to operate the image. Since this test is
> > focusing on image fleecing, skip skip that format.
> > 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  tests/qemu-iotests/222 | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> > index ff3bfc1470..0ead56d574 100644
> > --- a/tests/qemu-iotests/222
> > +++ b/tests/qemu-iotests/222
> > @@ -25,6 +25,8 @@ import iotests
> >  from iotests import log, qemu_img, qemu_io, qemu_io_silent
> >  
> >  iotests.verify_platform(['linux'])
> > +iotests.verify_image_format(supported_fmts=['qcow2', 'qcow', 'qed', 'vmdk',
> > +                                            'vhdx', 'raw'])
> >  
> >  patterns = [("0x5d", "0",         "64k"),
> >              ("0xd5", "1M",        "64k"),
> > 
> 
> Ah; do we not have a nicer way to exclude just one format? Evidently not.

iotest.verify_image_format() has an argument unsupported_fmts, but I
think a whitelist is better anyway.

Kevin