Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180709174154.9470-1-ehabkost@redhat.com
Subject: [Qemu-devel] [PULL 0/2] Machine/NUMA fixes for -rc0
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180709174154.9470-1-ehabkost@redhat.com -> patchew/20180709174154.9470-1-ehabkost@redhat.com
Switched to a new branch 'test'
4956ab47be hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()
daaacdfd4b machine: properly free device_memory
=== OUTPUT BEGIN ===
Checking PATCH 1/2: machine: properly free device_memory...
Checking PATCH 2/2: hw/machine: Remove the Zero check of nb_numa_nodes for numa_complete_configuration()...
ERROR: braces {} are necessary for all arms of this statement
#34: FILE: hw/core/machine.c:796:
+ if (nb_numa_nodes)
[...]
total: 1 errors, 0 warnings, 12 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com