Hi; this target-arm pull request has a collection of generally

fairly minor bugs to sneak in before 3.0 rc0 tomorrow...

The following changes since commit a98ff0ec2ba3538dd766b349518ee18d03942ed8:

Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.0-20180709' into staging (2018-07-09 11:00:45 +0100)

git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20180709

for you to fetch changes up to 8fad0a65582c0a6e324580f45516461e9b6aa439:

hw/net/dp8393x: don't make prom region 'nomigrate' (2018-07-09 14:51:35 +0100)

* hw/net/dp8393x: don't make prom region 'nomigrate'

* boards.h: Remove doc comment reference to nonexistent function

* hw/sd/omap_mmc: Split 'pseudo-reset' from 'power-on-reset'

* target/arm: Fix do_predset for large VL

* tcg: Restrict check_size_impl to multiples of the line size

* target/arm: Suppress Coverity warning for PRF

* hw/timer/cmsdk-apb-timer: fix minor corner-case bugs and

suppress spurious warnings when running Linux's timer driver

* hw/arm/smmu-common: Fix devfn computation in smmu_iommu_mr

Eric Auger (1):

hw/arm/smmu-common: Fix devfn computation in smmu_iommu_mr

Guenter Roeck (1):

hw/timer/cmsdk-apb-timer: Correctly identify and set one-shot mode

Peter Maydell (5):

ptimer: Add TRIGGER_ONLY_ON_DECREMENT policy option

hw/timer/cmsdk-apb-timer: Correct ptimer policy settings

hw/timer/cmsdk-apb-timer: run or stop timer on writes to RELOAD and VALUE

boards.h: Remove doc comment reference to nonexistent function

hw/net/dp8393x: don't make prom region 'nomigrate'

Philippe Mathieu-Daudé (1):

hw/sd/omap_mmc: Split 'pseudo-reset' from 'power-on-reset'

Richard Henderson (3):

target/arm: Suppress Coverity warning for PRF

tcg: Restrict check_size_impl to multiples of the line size

target/arm: Fix do_predset for large VL

include/hw/arm/smmu-common.h | 1 +

include/hw/boards.h | 3 +--

include/hw/ptimer.h | 9 +++++++++

hw/arm/smmu-common.c | 2 +-

hw/core/ptimer.c | 22 +++++++++++++++++++++-

hw/net/dp8393x.c | 2 +-

hw/sd/omap_mmc.c | 14 +++++++++++---

hw/timer/cmsdk-apb-timer.c | 20 ++++++++++++++++++--

target/arm/translate-sve.c | 14 ++++----------

tcg/tcg-op-gvec.c | 7 +++++--

tests/ptimer-test.c | 25 +++++++++++++++++++------

11 files changed, 91 insertions(+), 28 deletions(-)

These instructions must perform the sve_access_check, but

since they are implemented as NOPs there is no generated

code to elide when the access check fails.

Fixes: Coverity issues 1393780 & 1393779.

target/arm/translate-sve.c | 4 ++--

1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c

--- a/target/arm/translate-sve.c

+++ b/target/arm/translate-sve.c

@@ -XXX,XX +XXX,XX @@ static bool trans_ST1_zpiz(DisasContext *s, arg_ST1_zpiz *a, uint32_t insn)

static bool trans_PRF(DisasContext *s, arg_PRF *a, uint32_t insn)

{

/* Prefetch is a nop within QEMU. */

- sve_access_check(s);

+ (void)sve_access_check(s);

return true;

}

@@ -XXX,XX +XXX,XX @@ static bool trans_PRF_rr(DisasContext *s, arg_PRF_rr *a, uint32_t insn)

return false;

}

/* Prefetch is a nop within QEMU. */

- sve_access_check(s);

+ (void)sve_access_check(s);

return true;

}

2.17.1

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

DeviceClass::reset models a "cold power-on" reset which can

also be used to powercycle a device; but there is no "hot reset"

(a.k.a. soft-reset) method available.

The OMAP MMC Power-Up Control bit is not designed to powercycle

a card, but to disable it without powering it off (pseudo-reset):

Multimedia Card (MMC/SD/SDIO) Interface [SPRU765A]

MMC_CON[11] Power-Up Control (POW)

This bit must be set to 1 before any valid transaction to either

MMC/SD or SPI memory cards.

When 1, the card is considered powered-up and the controller core

is enabled.

When 0, the card is considered powered-down (system dependent),

and the controller core logic is in pseudo-reset state. This is,

the MMC_STAT flags and the FIFO pointers are reset, any access to

MMC_DATA[DATA] has no effect, a write into the MMC.CMD register

is ignored, and a setting of MMC_SPI[STR] to 1 is ignored.

By splitting the 'pseudo-reset' code out of the 'power-on' reset

function, this patch fixes a latent bug in omap_mmc_write(MMC_CON)i

recently exposed by ecd219f7abb.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Message-id: 20180706162155.8432-2-f4bug@amsat.org

hw/sd/omap_mmc.c | 14 +++++++++++---

1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/hw/sd/omap_mmc.c b/hw/sd/omap_mmc.c

--- a/hw/sd/omap_mmc.c

+++ b/hw/sd/omap_mmc.c

@@ -XXX,XX +XXX,XX @@

/*

* OMAP on-chip MMC/SD host emulation.

*

+ * Datasheet: TI Multimedia Card (MMC/SD/SDIO) Interface (SPRU765A)

+ *

* Copyright (C) 2006-2007 Andrzej Zaborowski <balrog@zabor.org>

*

* This program is free software; you can redistribute it and/or

@@ -XXX,XX +XXX,XX @@ static void omap_mmc_update(void *opaque)

omap_mmc_interrupts_update(s);

+static void omap_mmc_pseudo_reset(struct omap_mmc_s *host)

+ host->status = 0;

+ host->fifo_len = 0;

void omap_mmc_reset(struct omap_mmc_s *host)

{

host->last_cmd = 0;

@@ -XXX,XX +XXX,XX @@ void omap_mmc_reset(struct omap_mmc_s *host)

host->dw = 0;

host->mode = 0;

host->enable = 0;

- host->status = 0;

host->mask = 0;

host->cto = 0;

host->dto = 0;

- host->fifo_len = 0;

host->blen = 0;

host->blen_counter = 0;

host->nblk = 0;

@@ -XXX,XX +XXX,XX @@ void omap_mmc_reset(struct omap_mmc_s *host)

qemu_set_irq(host->coverswitch, host->cdet_state);

host->clkdiv = 0;

+ omap_mmc_pseudo_reset(host);

+

/* Since we're still using the legacy SD API the card is not plugged

* into any bus, and we must reset it manually. When omap_mmc is

* QOMified this must move into the QOM reset function.

@@ -XXX,XX +XXX,XX @@ static void omap_mmc_write(void *opaque, hwaddr offset,

if (s->dw != 0 && s->lines < 4)

printf("4-bit SD bus enabled\n");

if (!s->enable)

- omap_mmc_reset(s);

+ omap_mmc_pseudo_reset(s);

break;

case 0x10:    /* MMC_STAT */

2.17.1

The CMSDK APB timer is currently always configured as periodic timer.

This results in the following messages when trying to boot Linux.

Timer with delta zero, disabling

If the timer limit set with the RELOAD command is 0, the timer

needs to be enabled as one-shot timer.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Tested-by: Guenter Roeck <linux@roeck-us.net>

hw/timer/cmsdk-apb-timer.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/timer/cmsdk-apb-timer.c b/hw/timer/cmsdk-apb-timer.c

--- a/hw/timer/cmsdk-apb-timer.c

+++ b/hw/timer/cmsdk-apb-timer.c

@@ -XXX,XX +XXX,XX @@ static void cmsdk_apb_timer_write(void *opaque, hwaddr offset, uint64_t value,

s->ctrl = value & 0xf;

if (s->ctrl & R_CTRL_EN_MASK) {

- ptimer_run(s->timer, 0);

+ ptimer_run(s->timer, ptimer_get_limit(s->timer) == 0);

} else {

ptimer_stop(s->timer);

}

2.17.1

smmu_iommu_mr() aims at returning the IOMMUMemoryRegion corresponding

to a given sid. The function extracts both the PCIe bus number and

the devfn to return this data. Current computation of devfn is wrong

as it only returns the PCIe function instead of slot | function.

Fixes 32cfd7f39e08 ("hw/arm/smmuv3: Cache/invalidate config data")

Message-id: 1530775623-32399-1-git-send-email-eric.auger@redhat.com

include/hw/arm/smmu-common.h | 1 +

hw/arm/smmu-common.c | 2 +-

2 files changed, 2 insertions(+), 1 deletion(-)

@@ -XXX,XX +XXX,XX @@ IOMMUMemoryRegion *smmu_iommu_mr(SMMUState *s, uint32_t sid)

bus_n = PCI_BUS_NUM(sid);

smmu_bus = smmu_find_smmu_pcibus(s, bus_n);

if (smmu_bus) {

- devfn = sid & 0x7;

+ devfn = SMMU_PCI_DEVFN(sid);

smmu = smmu_bus->pbdev[devfn];

if (smmu) {

return &smmu->iommu;

2.17.1

From: Richard Henderson <richard.henderson@linaro.org>

Use MAKE_64BIT_MASK instead of open-coding. Remove an odd

vector size check that is unlikely to be more profitable

than 3 64-bit integer stores. Correct the iteration for WORD

to avoid writing too much data.

Fixes RISU tests of PTRUE for VL 256.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Tested-by: Alex Bennée <alex.bennee@linaro.org>

Message-id: 20180705191929.30773-3-richard.henderson@linaro.org

target/arm/translate-sve.c | 10 ++--------

1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c

--- a/target/arm/translate-sve.c

+++ b/target/arm/translate-sve.c

@@ -XXX,XX +XXX,XX @@ static bool do_predset(DisasContext *s, int esz, int rd, int pat, bool setflag)

setsz = numelem << esz;

lastword = word = pred_esz_masks[esz];

if (setsz % 64) {

- lastword &= ~(-1ull << (setsz % 64));

+ lastword &= MAKE_64BIT_MASK(0, setsz % 64);

}

@@ -XXX,XX +XXX,XX @@ static bool do_predset(DisasContext *s, int esz, int rd, int pat, bool setflag)

tcg_gen_gvec_dup64i(ofs, oprsz, maxsz, word);

goto done;

}

- if (oprsz * 8 == setsz + 8) {

- tcg_gen_gvec_dup64i(ofs, oprsz, maxsz, word);

- tcg_gen_movi_i64(t, 0);

- tcg_gen_st_i64(t, cpu_env, ofs + oprsz - 8);

- goto done;

- }

setsz /= 8;

fullsz /= 8;

tcg_gen_movi_i64(t, word);

- for (i = 0; i < setsz; i += 8) {

+ for (i = 0; i < QEMU_ALIGN_DOWN(setsz, 8); i += 8) {

tcg_gen_st_i64(t, cpu_env, ofs + i);

}

if (lastword != word) {

2.17.1

The CMSDK timer interrupt triggers when the counter goes from 1 to 0,

so we want to trigger immediately, rather than waiting for a

clock cycle. Drop the incorrect NO_IMMEDIATE_TRIGGER setting.

We also do not want to get an interrupt if the guest sets the

counter directly to zero, so use the new TRIGGER_ONLY_ON_DECREMENT

policy.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Tested-by: Guenter Roeck <linux@roeck-us.net>

Message-id: 20180703171044.9503-3-peter.maydell@linaro.org

hw/timer/cmsdk-apb-timer.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/timer/cmsdk-apb-timer.c b/hw/timer/cmsdk-apb-timer.c

--- a/hw/timer/cmsdk-apb-timer.c

+++ b/hw/timer/cmsdk-apb-timer.c

@@ -XXX,XX +XXX,XX @@ static void cmsdk_apb_timer_realize(DeviceState *dev, Error **errp)

bh = qemu_bh_new(cmsdk_apb_timer_tick, s);

s->timer = ptimer_init(bh,

PTIMER_POLICY_WRAP_AFTER_ONE_PERIOD |

- PTIMER_POLICY_NO_IMMEDIATE_TRIGGER |

+ PTIMER_POLICY_TRIGGER_ONLY_ON_DECREMENT |

PTIMER_POLICY_NO_IMMEDIATE_RELOAD |

PTIMER_POLICY_NO_COUNTER_ROUND_DOWN);

2.17.1

If the CMSDK APB timer is set up with a zero RELOAD value

then it will count down to zero, fire once and then stay

at zero. From the point of view of the ptimer system, the

timer is disabled; but the enable bit in the CTRL register

is still set and if the guest subsequently writes to the

RELOAD or VALUE registers this should cause the timer to

start counting down again.

Add code to the write paths for RELOAD and VALUE so that

we correctly restart the timer in this situation.

Conversely, if the new RELOAD and VALUE are both zero,

we should stop the ptimer.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Tested-by: Guenter Roeck <linux@roeck-us.net>

Message-id: 20180703171044.9503-5-peter.maydell@linaro.org

hw/timer/cmsdk-apb-timer.c | 16 ++++++++++++++++

1 file changed, 16 insertions(+)

diff --git a/hw/timer/cmsdk-apb-timer.c b/hw/timer/cmsdk-apb-timer.c

--- a/hw/timer/cmsdk-apb-timer.c

+++ b/hw/timer/cmsdk-apb-timer.c

@@ -XXX,XX +XXX,XX @@ static void cmsdk_apb_timer_write(void *opaque, hwaddr offset, uint64_t value,

break;

case A_RELOAD:

/* Writing to reload also sets the current timer value */

+ if (!value) {

+ ptimer_stop(s->timer);

+ }

ptimer_set_limit(s->timer, value, 1);

+ if (value && (s->ctrl & R_CTRL_EN_MASK)) {

+ /*

+ * Make sure timer is running (it might have stopped if this

+ * was an expired one-shot timer)

+ */

+ ptimer_run(s->timer, 0);

+ }

break;

case A_VALUE:

+ if (!value && !ptimer_get_limit(s->timer)) {

+ ptimer_stop(s->timer);

+ }

ptimer_set_count(s->timer, value);

+ if (value && (s->ctrl & R_CTRL_EN_MASK)) {

+ ptimer_run(s->timer, ptimer_get_limit(s->timer) == 0);

+ }

break;

case A_INTSTATUS:

/* Just one bit, which is W1C. */