[Qemu-devel] [PATCH for-3.0 1/3] linux-user: Do not report "Unsupported syscall" by default

Philippe Mathieu-Daudé posted 3 patches 7 years, 4 months ago
[Qemu-devel] [PATCH for-3.0 1/3] linux-user: Do not report "Unsupported syscall" by default
Posted by Philippe Mathieu-Daudé 7 years, 4 months ago
This can still be reported using the "-d unimp" command line option.

Fixes: https://bugs.launchpad.net/qemu/+bug/1777226
Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 linux-user/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 5822e03e28..e4b1b7d7da 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -12757,7 +12757,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
 
     default:
     unimplemented:
-        gemu_log("qemu: Unsupported syscall: %d\n", num);
+        qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
 #if defined(TARGET_NR_setxattr) || defined(TARGET_NR_get_thread_area) || defined(TARGET_NR_getdomainname) || defined(TARGET_NR_set_robust_list)
     unimplemented_nowarn:
 #endif
-- 
2.18.0


Re: [Qemu-devel] [PATCH for-3.0 1/3] linux-user: Do not report "Unsupported syscall" by default
Posted by Peter Maydell 7 years, 4 months ago
On 6 July 2018 at 16:51, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> This can still be reported using the "-d unimp" command line option.
>
> Fixes: https://bugs.launchpad.net/qemu/+bug/1777226
> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  linux-user/syscall.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 5822e03e28..e4b1b7d7da 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -12757,7 +12757,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>
>      default:
>      unimplemented:
> -        gemu_log("qemu: Unsupported syscall: %d\n", num);
> +        qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
>  #if defined(TARGET_NR_setxattr) || defined(TARGET_NR_get_thread_area) || defined(TARGET_NR_getdomainname) || defined(TARGET_NR_set_robust_list)
>      unimplemented_nowarn:
>  #endif
> --
> 2.18.0

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM