Sanitize linux-user stdout

[Qemu-devel] [PATCH for-3.0 0/3] Sanitize linux-user stdout

Philippe Mathieu-Daudé posted 3 patches 7 years, 4 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20180706155127.7483-1-f4bug@amsat.org

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

linux-user/alpha/cpu_loop.c      | 2 +-
linux-user/cris/cpu_loop.c       | 2 +-
linux-user/cris/signal.c         | 4 ++--
linux-user/microblaze/cpu_loop.c | 6 +++---
linux-user/microblaze/signal.c   | 4 ++--
linux-user/nios2/signal.c        | 2 +-
linux-user/sh4/cpu_loop.c        | 2 +-
linux-user/sparc/cpu_loop.c      | 2 +-
linux-user/sparc/signal.c        | 4 ++--
linux-user/syscall.c             | 2 +-
10 files changed, 15 insertions(+), 15 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH for-3.0 0/3] Sanitize linux-user stdout

Posted by Philippe Mathieu-Daudé 7 years, 4 months ago

Hi Laurent,

Here 3 trivial patches, the first one resolves this launchpad issue:
https://bugs.launchpad.net/qemu/+bug/1777226, then the following two
sanitize a bit further.

Regards,

Phil.

Philippe Mathieu-Daudé (3):
  linux-user: Do not report "Unsupported syscall" by default
  linux-user: Do not report "syscall not implemented" by default
  linux-user: Report error message on stderr, rather than stdout

 linux-user/alpha/cpu_loop.c      | 2 +-
 linux-user/cris/cpu_loop.c       | 2 +-
 linux-user/cris/signal.c         | 4 ++--
 linux-user/microblaze/cpu_loop.c | 6 +++---
 linux-user/microblaze/signal.c   | 4 ++--
 linux-user/nios2/signal.c        | 2 +-
 linux-user/sh4/cpu_loop.c        | 2 +-
 linux-user/sparc/cpu_loop.c      | 2 +-
 linux-user/sparc/signal.c        | 4 ++--
 linux-user/syscall.c             | 2 +-
 10 files changed, 15 insertions(+), 15 deletions(-)

-- 
2.18.0

Re: [Qemu-devel] [PATCH for-3.0 0/3] Sanitize linux-user stdout

Posted by Richard Henderson 7 years, 4 months ago

On 07/06/2018 08:51 AM, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (3):
>   linux-user: Do not report "Unsupported syscall" by default
>   linux-user: Do not report "syscall not implemented" by default
>   linux-user: Report error message on stderr, rather than stdout

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [Qemu-devel] [PATCH for-3.0 0/3] Sanitize linux-user stdout

Posted by Laurent Vivier 7 years, 3 months ago

Le 06/07/2018 à 17:51, Philippe Mathieu-Daudé a écrit :
> Hi Laurent,
> 
> Here 3 trivial patches, the first one resolves this launchpad issue:
> https://bugs.launchpad.net/qemu/+bug/1777226, then the following two
> sanitize a bit further.
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (3):
>   linux-user: Do not report "Unsupported syscall" by default
>   linux-user: Do not report "syscall not implemented" by default
>   linux-user: Report error message on stderr, rather than stdout
> 
>  linux-user/alpha/cpu_loop.c      | 2 +-
>  linux-user/cris/cpu_loop.c       | 2 +-
>  linux-user/cris/signal.c         | 4 ++--
>  linux-user/microblaze/cpu_loop.c | 6 +++---
>  linux-user/microblaze/signal.c   | 4 ++--
>  linux-user/nios2/signal.c        | 2 +-
>  linux-user/sh4/cpu_loop.c        | 2 +-
>  linux-user/sparc/cpu_loop.c      | 2 +-
>  linux-user/sparc/signal.c        | 4 ++--
>  linux-user/syscall.c             | 2 +-
>  10 files changed, 15 insertions(+), 15 deletions(-)
> 

I have queued the series for the next pull request.

I think you can also replace the gemu_log("Unknown QEMU_IFLA..."),
qemu_log("Unknown host ..") and qemu_log("Unknown target ...") from the
netlink part in syscall.c with qemu_log_mask(LOG_UNIMP, ...).

Thanks,
Laurent