Let's not chisel --preconfig in stone without a user

[Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user

Markus Armbruster posted 2 patches 7 years, 7 months ago

Download series mbox

Failed in applying to current master (apply log)

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

hmp.c                      |  2 +-
qapi/introspect.json       |  5 +----
qapi/misc.json             |  6 +++---
qemu-options.hx            |  9 +++++----
qemu-tech.texi             | 11 ++++-------
qmp.c                      |  2 +-
scripts/qapi/introspect.py |  3 +--
tests/numa-test.c          |  2 +-
tests/qmp-test.c           |  6 +++---
9 files changed, 20 insertions(+), 26 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user

Posted by Markus Armbruster 7 years, 7 months ago

Please refer to PATCH 1 for rationale.

Markus Armbruster (2):
  qapi: Do not expose "allow-preconfig" in query-qmp-schema
  cli qmp: Mark --preconfig, exit-preconfig experimental

 hmp.c                      |  2 +-
 qapi/introspect.json       |  5 +----
 qapi/misc.json             |  6 +++---
 qemu-options.hx            |  9 +++++----
 qemu-tech.texi             | 11 ++++-------
 qmp.c                      |  2 +-
 scripts/qapi/introspect.py |  3 +--
 tests/numa-test.c          |  2 +-
 tests/qmp-test.c           |  6 +++---
 9 files changed, 20 insertions(+), 26 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user

Posted by Eduardo Habkost 7 years, 7 months ago

On Thu, Jul 05, 2018 at 11:14:00AM +0200, Markus Armbruster wrote:
> Please refer to PATCH 1 for rationale.

Justification is good.  We're far from having machine
initialization code (i.e. everything between the two main_loop()
calls) safe to run with an active QMP monitor.

Acked-by: Eduardo Habkost <ehabkost@redhat.com>

> 
> Markus Armbruster (2):
>   qapi: Do not expose "allow-preconfig" in query-qmp-schema
>   cli qmp: Mark --preconfig, exit-preconfig experimental
> 
>  hmp.c                      |  2 +-
>  qapi/introspect.json       |  5 +----
>  qapi/misc.json             |  6 +++---
>  qemu-options.hx            |  9 +++++----
>  qemu-tech.texi             | 11 ++++-------
>  qmp.c                      |  2 +-
>  scripts/qapi/introspect.py |  3 +--
>  tests/numa-test.c          |  2 +-
>  tests/qmp-test.c           |  6 +++---
>  9 files changed, 20 insertions(+), 26 deletions(-)
> 
> -- 
> 2.17.1
> 

-- 
Eduardo

Re: [Qemu-devel] [PATCH 0/2] Let's not chisel --preconfig in stone without a user

Posted by Igor Mammedov 7 years, 7 months ago

On Thu,  5 Jul 2018 11:14:00 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Please refer to PATCH 1 for rationale.
> 
> Markus Armbruster (2):
>   qapi: Do not expose "allow-preconfig" in query-qmp-schema
>   cli qmp: Mark --preconfig, exit-preconfig experimental
> 
>  hmp.c                      |  2 +-
>  qapi/introspect.json       |  5 +----
>  qapi/misc.json             |  6 +++---
>  qemu-options.hx            |  9 +++++----
>  qemu-tech.texi             | 11 ++++-------
>  qmp.c                      |  2 +-
>  scripts/qapi/introspect.py |  3 +--
>  tests/numa-test.c          |  2 +-
>  tests/qmp-test.c           |  6 +++---
>  9 files changed, 20 insertions(+), 26 deletions(-)
> 

Acked-by: Igor Mammedov <imammedo@redhat.com>