[Qemu-devel] [PATCH 1/8] qobject: Catch another straggler for use of qdict_put_str()

Philippe Mathieu-Daudé posted 8 patches 7 years, 4 months ago
There is a newer version of this series
[Qemu-devel] [PATCH 1/8] qobject: Catch another straggler for use of qdict_put_str()
Posted by Philippe Mathieu-Daudé 7 years, 4 months ago
Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/qobject.cocci \
            --macro-file scripts/cocci-macro-file.h \
            --dir . --in-place

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 qobject/block-qdict.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
index 80c653013f..ae363708ab 100644
--- a/qobject/block-qdict.c
+++ b/qobject/block-qdict.c
@@ -572,7 +572,7 @@ static QObject *qdict_crumple_for_keyval_qiv(QDict *src, Error **errp)
         if (!tmp) {
             tmp = qdict_clone_shallow(src);
         }
-        qdict_put(tmp, ent->key, qstring_from_str(s));
+        qdict_put_str(tmp, ent->key, s);
         g_free(buf);
     }
 
-- 
2.18.0


Re: [Qemu-devel] [PATCH 1/8] qobject: Catch another straggler for use of qdict_put_str()
Posted by Markus Armbruster 7 years, 4 months ago
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Patch created mechanically by rerunning:
>
>   $  spatch --sp-file scripts/coccinelle/qobject.cocci \
>             --macro-file scripts/cocci-macro-file.h \
>             --dir . --in-place
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  qobject/block-qdict.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qobject/block-qdict.c b/qobject/block-qdict.c
> index 80c653013f..ae363708ab 100644
> --- a/qobject/block-qdict.c
> +++ b/qobject/block-qdict.c
> @@ -572,7 +572,7 @@ static QObject *qdict_crumple_for_keyval_qiv(QDict *src, Error **errp)
>          if (!tmp) {
>              tmp = qdict_clone_shallow(src);
>          }
> -        qdict_put(tmp, ent->key, qstring_from_str(s));
> +        qdict_put_str(tmp, ent->key, s);
>          g_free(buf);
>      }

Reviewed-by: Markus Armbruster <armbru@redhat.com>